diff options
| author | Craig Topper <craig.topper@intel.com> | 2019-01-30 19:57:01 +0000 |
|---|---|---|
| committer | Craig Topper <craig.topper@intel.com> | 2019-01-30 19:57:01 +0000 |
| commit | 22b3de5b51f2d98252744217f45adaadeabec9da (patch) | |
| tree | 382575935396f75cf343f172747b67b66c391612 /llvm/test/CodeGen | |
| parent | e171ade25c9b7904f88ca8a370fcc7ced5671602 (diff) | |
| download | bcm5719-llvm-22b3de5b51f2d98252744217f45adaadeabec9da.tar.gz bcm5719-llvm-22b3de5b51f2d98252744217f45adaadeabec9da.zip | |
[X86] Mark EMMS and FEMMS as clobbering MM0-7 and ST0-7.
This fixes the test case in PR35982 by preventing MMX instructions that read MM0-7 from being moved below EMMS/FEMMS by the post RA scheduler.
Though as discussed in bugzilla, this is not a complete fix. There is still the possibility of reordering in IR or by the pre-RA scheduler.
Differential Revision: https://reviews.llvm.org/D57298
llvm-svn: 352660
Diffstat (limited to 'llvm/test/CodeGen')
| -rw-r--r-- | llvm/test/CodeGen/X86/pr35982.ll | 128 |
1 files changed, 42 insertions, 86 deletions
diff --git a/llvm/test/CodeGen/X86/pr35982.ll b/llvm/test/CodeGen/X86/pr35982.ll index 6f92f1adb09..5f0ac0ef1c6 100644 --- a/llvm/test/CodeGen/X86/pr35982.ll +++ b/llvm/test/CodeGen/X86/pr35982.ll @@ -3,49 +3,27 @@ ; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+mmx,+3dnowa -post-RA-scheduler=true | FileCheck %s --check-prefixes=CHECK,POST define float @PR35982_emms(<1 x i64>) nounwind { -; NOPOST-LABEL: PR35982_emms: -; NOPOST: # %bb.0: -; NOPOST-NEXT: pushl %ebp -; NOPOST-NEXT: movl %esp, %ebp -; NOPOST-NEXT: andl $-8, %esp -; NOPOST-NEXT: subl $16, %esp -; NOPOST-NEXT: movl 8(%ebp), %eax -; NOPOST-NEXT: movl 12(%ebp), %ecx -; NOPOST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; NOPOST-NEXT: movl %eax, {{[0-9]+}}(%esp) -; NOPOST-NEXT: movq {{[0-9]+}}(%esp), %mm0 -; NOPOST-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] -; NOPOST-NEXT: movd %mm0, %ecx -; NOPOST-NEXT: emms -; NOPOST-NEXT: movl %eax, (%esp) -; NOPOST-NEXT: fildl (%esp) -; NOPOST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; NOPOST-NEXT: fiaddl {{[0-9]+}}(%esp) -; NOPOST-NEXT: movl %ebp, %esp -; NOPOST-NEXT: popl %ebp -; NOPOST-NEXT: retl -; -; POST-LABEL: PR35982_emms: -; POST: # %bb.0: -; POST-NEXT: pushl %ebp -; POST-NEXT: movl %esp, %ebp -; POST-NEXT: andl $-8, %esp -; POST-NEXT: subl $16, %esp -; POST-NEXT: movl 8(%ebp), %eax -; POST-NEXT: movl 12(%ebp), %ecx -; POST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; POST-NEXT: movl %eax, {{[0-9]+}}(%esp) -; POST-NEXT: movq {{[0-9]+}}(%esp), %mm0 -; POST-NEXT: emms -; POST-NEXT: movl %eax, (%esp) -; POST-NEXT: fildl (%esp) -; POST-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] -; POST-NEXT: movd %mm0, %ecx -; POST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; POST-NEXT: fiaddl {{[0-9]+}}(%esp) -; POST-NEXT: movl %ebp, %esp -; POST-NEXT: popl %ebp -; POST-NEXT: retl +; CHECK-LABEL: PR35982_emms: +; CHECK: # %bb.0: +; CHECK-NEXT: pushl %ebp +; CHECK-NEXT: movl %esp, %ebp +; CHECK-NEXT: andl $-8, %esp +; CHECK-NEXT: subl $16, %esp +; CHECK-NEXT: movl 8(%ebp), %eax +; CHECK-NEXT: movl 12(%ebp), %ecx +; CHECK-NEXT: movl %ecx, {{[0-9]+}}(%esp) +; CHECK-NEXT: movl %eax, {{[0-9]+}}(%esp) +; CHECK-NEXT: movq {{[0-9]+}}(%esp), %mm0 +; CHECK-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] +; CHECK-NEXT: movd %mm0, %ecx +; CHECK-NEXT: emms +; CHECK-NEXT: movl %eax, (%esp) +; CHECK-NEXT: fildl (%esp) +; CHECK-NEXT: movl %ecx, {{[0-9]+}}(%esp) +; CHECK-NEXT: fiaddl {{[0-9]+}}(%esp) +; CHECK-NEXT: movl %ebp, %esp +; CHECK-NEXT: popl %ebp +; CHECK-NEXT: retl %2 = bitcast <1 x i64> %0 to <2 x i32> %3 = extractelement <2 x i32> %2, i32 0 %4 = extractelement <1 x i64> %0, i32 0 @@ -61,49 +39,27 @@ define float @PR35982_emms(<1 x i64>) nounwind { } define float @PR35982_femms(<1 x i64>) nounwind { -; NOPOST-LABEL: PR35982_femms: -; NOPOST: # %bb.0: -; NOPOST-NEXT: pushl %ebp -; NOPOST-NEXT: movl %esp, %ebp -; NOPOST-NEXT: andl $-8, %esp -; NOPOST-NEXT: subl $16, %esp -; NOPOST-NEXT: movl 8(%ebp), %eax -; NOPOST-NEXT: movl 12(%ebp), %ecx -; NOPOST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; NOPOST-NEXT: movl %eax, {{[0-9]+}}(%esp) -; NOPOST-NEXT: movq {{[0-9]+}}(%esp), %mm0 -; NOPOST-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] -; NOPOST-NEXT: movd %mm0, %ecx -; NOPOST-NEXT: femms -; NOPOST-NEXT: movl %eax, (%esp) -; NOPOST-NEXT: fildl (%esp) -; NOPOST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; NOPOST-NEXT: fiaddl {{[0-9]+}}(%esp) -; NOPOST-NEXT: movl %ebp, %esp -; NOPOST-NEXT: popl %ebp -; NOPOST-NEXT: retl -; -; POST-LABEL: PR35982_femms: -; POST: # %bb.0: -; POST-NEXT: pushl %ebp -; POST-NEXT: movl %esp, %ebp -; POST-NEXT: andl $-8, %esp -; POST-NEXT: subl $16, %esp -; POST-NEXT: movl 8(%ebp), %eax -; POST-NEXT: movl 12(%ebp), %ecx -; POST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; POST-NEXT: movl %eax, {{[0-9]+}}(%esp) -; POST-NEXT: movq {{[0-9]+}}(%esp), %mm0 -; POST-NEXT: femms -; POST-NEXT: movl %eax, (%esp) -; POST-NEXT: fildl (%esp) -; POST-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] -; POST-NEXT: movd %mm0, %ecx -; POST-NEXT: movl %ecx, {{[0-9]+}}(%esp) -; POST-NEXT: fiaddl {{[0-9]+}}(%esp) -; POST-NEXT: movl %ebp, %esp -; POST-NEXT: popl %ebp -; POST-NEXT: retl +; CHECK-LABEL: PR35982_femms: +; CHECK: # %bb.0: +; CHECK-NEXT: pushl %ebp +; CHECK-NEXT: movl %esp, %ebp +; CHECK-NEXT: andl $-8, %esp +; CHECK-NEXT: subl $16, %esp +; CHECK-NEXT: movl 8(%ebp), %eax +; CHECK-NEXT: movl 12(%ebp), %ecx +; CHECK-NEXT: movl %ecx, {{[0-9]+}}(%esp) +; CHECK-NEXT: movl %eax, {{[0-9]+}}(%esp) +; CHECK-NEXT: movq {{[0-9]+}}(%esp), %mm0 +; CHECK-NEXT: punpckhdq %mm0, %mm0 # mm0 = mm0[1,1] +; CHECK-NEXT: movd %mm0, %ecx +; CHECK-NEXT: femms +; CHECK-NEXT: movl %eax, (%esp) +; CHECK-NEXT: fildl (%esp) +; CHECK-NEXT: movl %ecx, {{[0-9]+}}(%esp) +; CHECK-NEXT: fiaddl {{[0-9]+}}(%esp) +; CHECK-NEXT: movl %ebp, %esp +; CHECK-NEXT: popl %ebp +; CHECK-NEXT: retl %2 = bitcast <1 x i64> %0 to <2 x i32> %3 = extractelement <2 x i32> %2, i32 0 %4 = extractelement <1 x i64> %0, i32 0 |

