diff options
author | Sanjoy Das <sanjoy@playingwithpointers.com> | 2015-06-15 18:44:27 +0000 |
---|---|---|
committer | Sanjoy Das <sanjoy@playingwithpointers.com> | 2015-06-15 18:44:27 +0000 |
commit | 69fad0799e243f0df832f9b4a98cd74263d8d107 (patch) | |
tree | 25553a6a6a043b9ee7627ad77846613be2afe65b /llvm/test/CodeGen/X86/implicit-null-check-negative.ll | |
parent | 6b34a462983498c71fd6fb839ecd0e49e56de4ce (diff) | |
download | bcm5719-llvm-69fad0799e243f0df832f9b4a98cd74263d8d107.tar.gz bcm5719-llvm-69fad0799e243f0df832f9b4a98cd74263d8d107.zip |
[CodeGen] Add a pass to fold null checks into nearby memory operations.
Summary:
This change adds an "ImplicitNullChecks" target dependent pass. This
pass folds null checks into memory operation using the FAULTING_LOAD
pseudo-op introduced in previous patches.
Depends on D10197
Depends on D10199
Depends on D10200
Reviewers: reames, rnk, pgavlin, JosephTremoulet, atrick
Reviewed By: atrick
Subscribers: ab, JosephTremoulet, llvm-commits
Differential Revision: http://reviews.llvm.org/D10201
llvm-svn: 239743
Diffstat (limited to 'llvm/test/CodeGen/X86/implicit-null-check-negative.ll')
-rw-r--r-- | llvm/test/CodeGen/X86/implicit-null-check-negative.ll | 52 |
1 files changed, 52 insertions, 0 deletions
diff --git a/llvm/test/CodeGen/X86/implicit-null-check-negative.ll b/llvm/test/CodeGen/X86/implicit-null-check-negative.ll new file mode 100644 index 00000000000..0fcb0e95985 --- /dev/null +++ b/llvm/test/CodeGen/X86/implicit-null-check-negative.ll @@ -0,0 +1,52 @@ +; RUN: llc -mtriple=x86_64-apple-macosx -O3 -debug-only=faultmaps -enable-implicit-null-checks < %s | FileCheck %s + +; List cases where we should *not* be emitting implicit null checks. + +; CHECK-NOT: Fault Map Output + +define i32 @imp_null_check_load(i32* %x, i32* %y) { + entry: + %c = icmp eq i32* %x, null +; It isn't legal to move the load from %x from "not_null" to here -- +; the store to %y could be aliasing it. + br i1 %c, label %is_null, label %not_null + + is_null: + ret i32 42 + + not_null: + store i32 0, i32* %y + %t = load i32, i32* %x + ret i32 %t +} + +define i32 @imp_null_check_gep_load(i32* %x) { + entry: + %c = icmp eq i32* %x, null + br i1 %c, label %is_null, label %not_null + + is_null: + ret i32 42 + + not_null: +; null + 5000 * sizeof(i32) lies outside the null page and hence the +; load to %t cannot be assumed to be reliably faulting. + %x.gep = getelementptr i32, i32* %x, i32 5000 + %t = load i32, i32* %x.gep + ret i32 %t +} + +define i32 @imp_null_check_load_no_md(i32* %x) { +; Everything is okay except that the !never.executed metadata is +; missing. + entry: + %c = icmp eq i32* %x, null + br i1 %c, label %is_null, label %not_null + + is_null: + ret i32 42 + + not_null: + %t = load i32, i32* %x + ret i32 %t +} |