diff options
author | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-02-12 06:15:29 +0000 |
---|---|---|
committer | Ahmed Bougacha <ahmed.bougacha@gmail.com> | 2015-02-12 06:15:29 +0000 |
commit | 24433a7005835a551f3d71f61aa632db36f639b0 (patch) | |
tree | 6717b6486377a5a3c9407365a647edadf9cc6a85 /llvm/test/CodeGen/X86/fp-double-rounding.ll | |
parent | 92ee75c0b2352b4394832cbc71d059321e8854c3 (diff) | |
download | bcm5719-llvm-24433a7005835a551f3d71f61aa632db36f639b0.tar.gz bcm5719-llvm-24433a7005835a551f3d71f61aa632db36f639b0.zip |
[CodeGen] Don't blindly combine (fp_round (fp_round x)) to (fp_round x).
We used to do this DAG combine, but it's not always correct:
If the first fp_round isn't a value preserving truncation, it might
introduce a tie in the second fp_round, that wouldn't occur in the
single-step fp_round we want to fold to.
In other words, double rounding isn't the same as rounding.
Differential Revision: http://reviews.llvm.org/D7571
llvm-svn: 228911
Diffstat (limited to 'llvm/test/CodeGen/X86/fp-double-rounding.ll')
-rw-r--r-- | llvm/test/CodeGen/X86/fp-double-rounding.ll | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/llvm/test/CodeGen/X86/fp-double-rounding.ll b/llvm/test/CodeGen/X86/fp-double-rounding.ll new file mode 100644 index 00000000000..030cb9a3c01 --- /dev/null +++ b/llvm/test/CodeGen/X86/fp-double-rounding.ll @@ -0,0 +1,31 @@ +; RUN: llc < %s | FileCheck %s --check-prefix=CHECK --check-prefix=SAFE +; RUN: llc < %s -enable-unsafe-fp-math | FileCheck %s --check-prefix=CHECK --check-prefix=UNSAFE + +target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64--" + +; CHECK-LABEL: double_rounding: +; SAFE: callq __trunctfdf2 +; SAFE-NEXT: cvtsd2ss %xmm0 +; UNSAFE: callq __trunctfsf2 +; UNSAFE-NOT: cvt +define void @double_rounding(fp128* %x, float* %f) { +entry: + %0 = load fp128* %x, align 16 + %1 = fptrunc fp128 %0 to double + %2 = fptrunc double %1 to float + store float %2, float* %f, align 4 + ret void +} + +; CHECK-LABEL: double_rounding_precise_first: +; CHECK: fstps (% +; CHECK-NOT: fstpl +define void @double_rounding_precise_first(float* %f) { +entry: + ; Hack, to generate a precise FP_ROUND to double + %precise = call double asm sideeffect "fld %st(0)", "={st(0)}"() + %0 = fptrunc double %precise to float + store float %0, float* %f, align 4 + ret void +} |