diff options
| author | JF Bastien <jfb@google.com> | 2015-12-23 23:56:13 +0000 |
|---|---|---|
| committer | JF Bastien <jfb@google.com> | 2015-12-23 23:56:13 +0000 |
| commit | 3e9f10ad3dfbdc716ae090f97fdad0415492bdb3 (patch) | |
| tree | 31f010b87f69964979e828a0f29db3c9842a5748 /llvm/test/CodeGen/WebAssembly/offset-folding.ll | |
| parent | cb0f947a2a81730e054b39b0dfb4d90bd52cee61 (diff) | |
| download | bcm5719-llvm-3e9f10ad3dfbdc716ae090f97fdad0415492bdb3.tar.gz bcm5719-llvm-3e9f10ad3dfbdc716ae090f97fdad0415492bdb3.zip | |
WebAssembly: remove 'external' from test
Summary: Linker testing was sad at seeing an unresolved external symbol. For now don't do that: it's valid but we're not playing with multi-file linking yet, and the LLVM tests are used as hacky sanity tests for single-file linking (the GCC torture tests are much better for this purpose). Another solution would be to use '.extern' to make the intent explicit (don't simple-file link this, there's an unresolved symbol), some assemblers use '.extern' while others ignore it, so we wouldn't really be inventing anything new.
Reviewers: sunfish, kripken
Subscribers: jfb, llvm-commits, dschuff
Differential Revision: http://reviews.llvm.org/D15753
llvm-svn: 256353
Diffstat (limited to 'llvm/test/CodeGen/WebAssembly/offset-folding.ll')
| -rw-r--r-- | llvm/test/CodeGen/WebAssembly/offset-folding.ll | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/llvm/test/CodeGen/WebAssembly/offset-folding.ll b/llvm/test/CodeGen/WebAssembly/offset-folding.ll index 19b110fcfa8..2b4e8a90b0f 100644 --- a/llvm/test/CodeGen/WebAssembly/offset-folding.ll +++ b/llvm/test/CodeGen/WebAssembly/offset-folding.ll @@ -5,7 +5,10 @@ target datalayout = "e-p:32:32-i64:64-n32:64-S128" target triple = "wasm32-unknown-unknown" -@x = external global [0 x i32] +; FIXME: make this 'external' and make sure it still works. WebAssembly +; currently only supports linking single files, so 'external' makes +; little sense. +@x = global [0 x i32] zeroinitializer @y = global [50 x i32] zeroinitializer ; Test basic constant offsets of both defined and external symbols. |
