diff options
| author | Fangrui Song <maskray@google.com> | 2018-10-22 23:43:53 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2018-10-22 23:43:53 +0000 |
| commit | efc0fe5a72f80234ac66ebff0d2431616ea86180 (patch) | |
| tree | 8da74ac52d1bdde13f8a10e2589f2398c2199934 /llvm/test/CodeGen/WebAssembly/function-bitcasts-varargs.ll | |
| parent | 96cd3cc312d4498e730f348fac31ec4b3432d817 (diff) | |
| download | bcm5719-llvm-efc0fe5a72f80234ac66ebff0d2431616ea86180.tar.gz bcm5719-llvm-efc0fe5a72f80234ac66ebff0d2431616ea86180.zip | |
[ELF] Don't warn on two legitimate cases when reading .llvm.call-graph-profile
Summary:
Before, superfluous warnings were emitted for the following two cases:
1) When from symbol was in a discarded section.
The profile should be thought of as affiliated to the section.
It makes sense to ignore the profile if the section is discarded.
2) When to symbol was in a shared object.
The object file containing the profile may not know about the to
symbol, which can reside in another object file (useful profile) or a
shared object (not useful as symbols in the shared object are fixed
and unorderable). It makes sense to ignore the profile from the object
file.
Note, the warning when to symbol was undefined was suppressed in
D53044, which is still useful for --symbol-ordering-file=
This patch silences the warnings. The check is actually more relaxed (no
warnings if either From or To is not Defined) for simplicity and I don't
see a compelling reason to warn on more cases.
Reviewers: ruiu, davidxl, espindola, Bigcheese
Reviewed By: ruiu
Subscribers: emaste, arichardson, llvm-commits
Differential Revision: https://reviews.llvm.org/D53470
llvm-svn: 344974
Diffstat (limited to 'llvm/test/CodeGen/WebAssembly/function-bitcasts-varargs.ll')
0 files changed, 0 insertions, 0 deletions

