diff options
| author | Tim Northover <tnorthover@apple.com> | 2016-04-13 23:08:27 +0000 |
|---|---|---|
| committer | Tim Northover <tnorthover@apple.com> | 2016-04-13 23:08:27 +0000 |
| commit | 5c02f9ad28b02eccd04e10c5c1574b97bc9564fb (patch) | |
| tree | 98b42b7e983290bee0005a611558888fec73b487 /llvm/test/CodeGen/ARM/lsr-code-insertion.ll | |
| parent | 2a734db7d3418cae537c63337d77243a22b2db81 (diff) | |
| download | bcm5719-llvm-5c02f9ad28b02eccd04e10c5c1574b97bc9564fb.tar.gz bcm5719-llvm-5c02f9ad28b02eccd04e10c5c1574b97bc9564fb.zip | |
ARM: override cost function to re-enable ConstantHoisting (& fix it).
At some point, ARM stopped getting any benefit from ConstantHoisting because
the pass called a different variant of getIntImmCost. Reimplementing the
correct variant revealed some problems, however:
+ ConstantHoisting was modifying switch statements. This is simply invalid,
the cases must remain integer constants no matter the notional cost.
+ ConstantHoisting was mangling alloca instructions in the entry block. These
should be handled by FrameLowering, so constants actually have a cost of 0.
Worse, the resulting bitcasts meant they became dynamic allocas.
rdar://25707382
llvm-svn: 266260
Diffstat (limited to 'llvm/test/CodeGen/ARM/lsr-code-insertion.ll')
| -rw-r--r-- | llvm/test/CodeGen/ARM/lsr-code-insertion.ll | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/test/CodeGen/ARM/lsr-code-insertion.ll b/llvm/test/CodeGen/ARM/lsr-code-insertion.ll index aa2b2d26d12..766710fd1d6 100644 --- a/llvm/test/CodeGen/ARM/lsr-code-insertion.ll +++ b/llvm/test/CodeGen/ARM/lsr-code-insertion.ll @@ -9,8 +9,8 @@ ; ; CHECK: ldr [[R6:r[0-9*]+]], LCP ; CHECK: cmp {{.*}}, [[R6]] -; CHECK: ldrle -; CHECK-NEXT: strle +; CHECK-NOT: lt +; CHECK: strlt target triple = "arm-apple-darwin8" |
