diff options
| author | Bjorn Pettersson <bjorn.a.pettersson@ericsson.com> | 2018-01-05 22:20:30 +0000 |
|---|---|---|
| committer | Bjorn Pettersson <bjorn.a.pettersson@ericsson.com> | 2018-01-05 22:20:30 +0000 |
| commit | 5ffb1c0ff02d389b0feebf864332188b83cb9fdf (patch) | |
| tree | 369e7f046c4e65629fc0d851af712d2a7cc547c3 /llvm/test/CodeGen/ARM/debug-info-qreg.ll | |
| parent | c192d1942e4186a6990d22228bf421612242836a (diff) | |
| download | bcm5719-llvm-5ffb1c0ff02d389b0feebf864332188b83cb9fdf.tar.gz bcm5719-llvm-5ffb1c0ff02d389b0feebf864332188b83cb9fdf.zip | |
[DebugInfo] Align comments in debug_loc section
Summary:
This commit updates the BufferByteStreamer, used by DebugLocStream
to buffer bytes/comments to put in the debug_loc section, to
make sure that the Buffer and Comments vectors are synced.
Previously, when an SLEB128 or ULEB128 was emitted together with
a comment, the vectors could be out-of-sync if the LEB encoding
added several entries to the Buffer vectors, while we only added
a single entry to the Comments vector.
The goal with this is to get the comments in the debug_loc
section in the .s file correctly aligned.
Example (using ARM as target):
Instead of
.byte 144 @ sub-register DW_OP_regx
.byte 128 @ 256
.byte 2 @ DW_OP_piece
.byte 147 @ 8
.byte 8 @ sub-register DW_OP_regx
.byte 144 @ 257
.byte 129 @ DW_OP_piece
.byte 2 @ 8
.byte 147 @
.byte 8 @
we now get
.byte 144 @ sub-register DW_OP_regx
.byte 128 @ 256
.byte 2 @
.byte 147 @ DW_OP_piece
.byte 8 @ 8
.byte 144 @ sub-register DW_OP_regx
.byte 129 @ 257
.byte 2 @
.byte 147 @ DW_OP_piece
.byte 8 @ 8
Reviewers: JDevlieghere, rnk, aprantl
Reviewed By: aprantl
Subscribers: davide, Ka-Ka, uabelho, aemerson, javed.absar, kristof.beyls, llvm-commits, JDevlieghere
Differential Revision: https://reviews.llvm.org/D41763
llvm-svn: 321907
Diffstat (limited to 'llvm/test/CodeGen/ARM/debug-info-qreg.ll')
| -rw-r--r-- | llvm/test/CodeGen/ARM/debug-info-qreg.ll | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/llvm/test/CodeGen/ARM/debug-info-qreg.ll b/llvm/test/CodeGen/ARM/debug-info-qreg.ll index 658e730bddd..44d30f871b1 100644 --- a/llvm/test/CodeGen/ARM/debug-info-qreg.ll +++ b/llvm/test/CodeGen/ARM/debug-info-qreg.ll @@ -4,10 +4,12 @@ target triple = "thumbv7-apple-macosx10.6.7" ;CHECK: sub-register DW_OP_regx ;CHECK-NEXT: 256 +;CHECK-NEXT: @ ;CHECK-NEXT: DW_OP_piece ;CHECK-NEXT: 8 ;CHECK-NEXT: sub-register DW_OP_regx ;CHECK-NEXT: 257 +;CHECK-NEXT: @ ;CHECK-NEXT: DW_OP_piece ;CHECK-NEXT: 8 |
