diff options
| author | Haojian Wu <hokein@google.com> | 2018-02-22 13:35:01 +0000 |
|---|---|---|
| committer | Haojian Wu <hokein@google.com> | 2018-02-22 13:35:01 +0000 |
| commit | b603a5e0e3760eb8148e327bb184d60d6b6bfbd7 (patch) | |
| tree | 2640be9123cff5af4c679a3cb6022151bc1604cf /llvm/test/Bitcode | |
| parent | 1fb81bcb9bb4ba5571b24847713894623e67a926 (diff) | |
| download | bcm5719-llvm-b603a5e0e3760eb8148e327bb184d60d6b6bfbd7.tar.gz bcm5719-llvm-b603a5e0e3760eb8148e327bb184d60d6b6bfbd7.zip | |
[clangd] Correct setting ignoreWarnings in CodeCompletion.
Summary:
We should set the flag before creating ComplierInstance -- when
CopmilerInstance gets initialized, it also initializes the DiagnosticsEngine
using the DiagnosticOptions.
This was hidden deeply -- as clang suppresses all diagnostics when we
hit the code-completion (but internally it does do unnecessary analysis stuff).
As a bonus point, this fix will optmize the completion speed -- clang won't do
any analysis (e.g. -Wunreachable-code, -Wthread-safety-analysisi) at all internally.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, jkorous-apple, ioeric, cfe-commits
Differential Revision: https://reviews.llvm.org/D43569
llvm-svn: 325779
Diffstat (limited to 'llvm/test/Bitcode')
0 files changed, 0 insertions, 0 deletions
