diff options
| author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2014-08-01 22:27:19 +0000 |
|---|---|---|
| committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2014-08-01 22:27:19 +0000 |
| commit | 6e1009b65e985412267d5e263a99afbcdd5ae936 (patch) | |
| tree | d29878235a592736142d339b6a6742b21da270e9 /llvm/test/Bitcode | |
| parent | 3516669a50bb64ee7d27c0bbc00b2439477071bf (diff) | |
| download | bcm5719-llvm-6e1009b65e985412267d5e263a99afbcdd5ae936.tar.gz bcm5719-llvm-6e1009b65e985412267d5e263a99afbcdd5ae936.zip | |
UseListOrder: Fix blockaddress use-list order
`parseBitcodeFile()` uses the generic `getLazyBitcodeFile()` function as
a helper. Since `parseBitcodeFile()` isn't actually lazy -- it calls
`MaterializeAllPermanently()` -- bypass the unnecessary call to
`materializeForwardReferencedFunctions()` by extracting out a common
helper function. This removes the last of the use-list churn caused by
blockaddresses.
This highlights that we can't reproduce use-list order of globals and
constants when parsing lazily -- but that's necessarily out of scope.
When we're parsing lazily, we never have all the functions in memory, so
the use-lists of globals (and constants that reference globals) are
always incomplete.
This is part of PR5680.
llvm-svn: 214581
Diffstat (limited to 'llvm/test/Bitcode')
| -rw-r--r-- | llvm/test/Bitcode/blockaddress.ll | 1 | ||||
| -rw-r--r-- | llvm/test/Bitcode/use-list-order.ll | 35 |
2 files changed, 36 insertions, 0 deletions
diff --git a/llvm/test/Bitcode/blockaddress.ll b/llvm/test/Bitcode/blockaddress.ll index 8ac54be00d5..305118c83b8 100644 --- a/llvm/test/Bitcode/blockaddress.ll +++ b/llvm/test/Bitcode/blockaddress.ll @@ -1,4 +1,5 @@ ; RUN: llvm-as < %s | llvm-dis | FileCheck %s +; RUN: verify-uselistorder < %s -preserve-bc-use-list-order ; PR9857 define void @f(i8** nocapture %ptr1) { diff --git a/llvm/test/Bitcode/use-list-order.ll b/llvm/test/Bitcode/use-list-order.ll index ccd9e968465..5309857c2d6 100644 --- a/llvm/test/Bitcode/use-list-order.ll +++ b/llvm/test/Bitcode/use-list-order.ll @@ -131,3 +131,38 @@ loop2: %var = phi i32 [ %var, %loop1 ], [ %var, %loop2 ] br label %loop1 } + +; Check that block addresses work. +@ba1 = constant i8* blockaddress (@bafunc1, %bb) +@ba2 = constant i8* getelementptr (i8* blockaddress (@bafunc2, %bb), i61 0) +@ba3 = constant i8* getelementptr (i8* blockaddress (@bafunc2, %bb), i61 0) + +define i8* @babefore() { + ret i8* getelementptr (i8* blockaddress (@bafunc2, %bb), i61 0) +bb1: + ret i8* blockaddress (@bafunc1, %bb) +bb2: + ret i8* blockaddress (@bafunc3, %bb) +} +define void @bafunc1() { + unreachable +bb: + unreachable +} +define void @bafunc2() { + unreachable +bb: + unreachable +} +define void @bafunc3() { + unreachable +bb: + unreachable +} +define i8* @baafter() { + ret i8* blockaddress (@bafunc2, %bb) +bb1: + ret i8* blockaddress (@bafunc1, %bb) +bb2: + ret i8* blockaddress (@bafunc3, %bb) +} |
