[ObjC][ARC] Check whether the return and parameter types of the old and

new functions are compatible before upgrading a function call to an
intrinsic call.

Sometimes users insert calls to ARC runtime functions that are not
compatible with the corresponding intrinsic functions (for example,
'i8* @objc_storeStrong' instead of 'void @objc_storeStrong'). Don't
upgrade those calls.

rdar://problem/56447127

2 files changed, 21 insertions, 0 deletions

diff --git a/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.bc b/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.bc
new file mode 100644
index 00000000000..f2af475b26c
--- /dev/null
+++ b/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.bc
diff --git a/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.ll b/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.ll
new file mode 100644
index 00000000000..deac12d36df
--- /dev/null
+++ b/llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.ll
@@ -0,0 +1,21 @@
+target triple = "arm64-apple-ios7.0"
+
+; RUN: llvm-dis < %S/upgrade-arc-runtime-calls-bitcast.bc | FileCheck %s
+
+; CHECK: tail call i8* @objc_retain(i32 1)
+; CHECK: tail call i8* @objc_storeStrong(
+
+define void @testRuntimeCalls(i8* %a, i8** %b) {
+  %v6 = tail call i8* @objc_retain(i32 1)
+  %1 = tail call i8* @objc_storeStrong(i8** %b, i8* %a)
+  ret void
+}
+
+declare i8* @objc_retain(i32)
+declare i8* @objc_storeStrong(i8**, i8*)
+
+attributes #0 = { nounwind }
+
+!llvm.module.flags = !{!0}
+
+!0 = !{i32 1, !"clang.arc.retainAutoreleasedReturnValueMarker", !"mov\09fp, fp\09\09; marker for objc_retainAutoreleaseReturnValue"}