diff options
| author | Fangrui Song <maskray@google.com> | 2019-08-02 16:31:38 +0000 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2019-08-02 16:31:38 +0000 |
| commit | e93341f7c87e6816a8026d8bdd2a59e2f71f56a9 (patch) | |
| tree | d34ddd78366de4e6e1504267ce45697032af2c24 /llvm/test/Bitcode/function-default-address-spaces.ll | |
| parent | 89683e9dd7db4693061b765923518cc040842ecf (diff) | |
| download | bcm5719-llvm-e93341f7c87e6816a8026d8bdd2a59e2f71f56a9.tar.gz bcm5719-llvm-e93341f7c87e6816a8026d8bdd2a59e2f71f56a9.zip | |
[Sema] Disable -Wbitwise-op-parentheses and -Wlogical-op-parentheses by default
Summary:
The -Wparentheses warnings are enabled by default in clang but they are under
-Wall in gcc (gcc/c-family/c.opt). Some of the operator precedence warnings are
oftentimes criticized as noise (clang: default; gcc: -Wall). If a warning is
very controversial, it is probably not a good idea to enable it by default.
This patch disables the rather annoying ones:
-Wbitwise-op-parentheses, e.g. i & i | i
-Wlogical-op-parentheses, e.g. i && i || i
After this change:
```
* = enabled by default
-Wall
-Wparentheses
-Wlogical-op-parentheses
-Wlogical-not-parentheses*
-Wbitwise-op-parentheses
-Wshift-op-parentheses*
-Woverloaded-shift-op-parentheses*
-Wparentheses-equality*
-Wdangling-else*
```
-Woverloaded-shift-op-parentheses is typically followed by overload
resolution failure. We can instead improve the error message, and
probably delete -Woverloaded-shift-op-parentheses in the future. Keep it
for now because it gives some diagnostics.
Reviewers: akyrtzi, jyknight, rtrieu, rsmith, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: dexonsmith, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D65192
llvm-svn: 367690
Diffstat (limited to 'llvm/test/Bitcode/function-default-address-spaces.ll')
0 files changed, 0 insertions, 0 deletions

