diff options
| author | David Tellenbach <david.tellenbach@arm.com> | 2019-10-28 18:57:53 +0000 |
|---|---|---|
| committer | David Tellenbach <david.tellenbach@arm.com> | 2019-10-28 18:58:45 +0000 |
| commit | e3a45a24d1077e2afc917024032715afa70fb2ac (patch) | |
| tree | 3ed3093e7e6016b6e6ec27e91077f9484f2e40f4 /llvm/lib | |
| parent | e59f7488c772f9e5fe4c8acd4da7312493fecb07 (diff) | |
| download | bcm5719-llvm-e3a45a24d1077e2afc917024032715afa70fb2ac.tar.gz bcm5719-llvm-e3a45a24d1077e2afc917024032715afa70fb2ac.zip | |
[ARM][Thumb2InstrInfo] Fix default `0` opcode when rewriting frame indices
The static functions `positiveOffsetOpcode`, `negativeOffsetOpcode` and
`immediateOffsetOpcode` (lib/Target/ARM/Thumb2InstrInfo.cpp) currently can
return `0` as default opcode which is meaningless in this situation.
This patch replaces this default value by llvm_unreachable.
Reviewers: t.p.northover, tellenbach
Reviewed By: tellenbach
Subscribers: tellenbach, kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69432
Patch By: Lorenzo Casalino <lorenzo.casalino93@gmail.com>
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Target/ARM/Thumb2InstrInfo.cpp | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/llvm/lib/Target/ARM/Thumb2InstrInfo.cpp b/llvm/lib/Target/ARM/Thumb2InstrInfo.cpp index af1f0aeb27b..ded7c48fd21 100644 --- a/llvm/lib/Target/ARM/Thumb2InstrInfo.cpp +++ b/llvm/lib/Target/ARM/Thumb2InstrInfo.cpp @@ -388,10 +388,8 @@ negativeOffsetOpcode(unsigned opcode) return opcode; default: - break; + llvm_unreachable("unknown thumb2 opcode."); } - - return 0; } static unsigned @@ -420,10 +418,8 @@ positiveOffsetOpcode(unsigned opcode) return opcode; default: - break; + llvm_unreachable("unknown thumb2 opcode."); } - - return 0; } static unsigned @@ -461,10 +457,8 @@ immediateOffsetOpcode(unsigned opcode) return opcode; default: - break; + llvm_unreachable("unknown thumb2 opcode."); } - - return 0; } bool llvm::rewriteT2FrameIndex(MachineInstr &MI, unsigned FrameRegIdx, |
