diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2011-07-08 21:06:23 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2011-07-08 21:06:23 +0000 |
| commit | debe69fb37c9b58d40cff05c6997a8eadd0c8bd8 (patch) | |
| tree | 5ab725e19b1f2d5ffe64054bd93a94103c14f785 /llvm/lib | |
| parent | cb1b0b7130387edaeab5bef07ef372b7908af4d5 (diff) | |
| download | bcm5719-llvm-debe69fb37c9b58d40cff05c6997a8eadd0c8bd8.tar.gz bcm5719-llvm-debe69fb37c9b58d40cff05c6997a8eadd0c8bd8.zip | |
Plug a leak by giving the AsmParser ownership of the MCSubtargetInfo.
Found by valgrind.
llvm-svn: 134738
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 7 | ||||
| -rw-r--r-- | llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp | 7 |
2 files changed, 8 insertions, 6 deletions
diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index d97f8a5b769..9438ee17757 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -25,6 +25,7 @@ #include "llvm/Target/TargetAsmParser.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/raw_ostream.h" +#include "llvm/ADT/OwningPtr.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringExtras.h" #include "llvm/ADT/StringSwitch.h" @@ -41,7 +42,7 @@ class ARMOperand; class ARMAsmParser : public TargetAsmParser { MCAsmParser &Parser; - const MCSubtargetInfo *STI; + OwningPtr<const MCSubtargetInfo> STI; MCAsmParser &getParser() const { return Parser; } MCAsmLexer &getLexer() const { return Parser.getLexer(); } @@ -128,8 +129,8 @@ class ARMAsmParser : public TargetAsmParser { public: ARMAsmParser(StringRef TT, StringRef CPU, StringRef FS, MCAsmParser &_Parser) - : TargetAsmParser(), Parser(_Parser) { - STI = ARM_MC::createARMMCSubtargetInfo(TT, CPU, FS); + : TargetAsmParser(), Parser(_Parser), + STI(ARM_MC::createARMMCSubtargetInfo(TT, CPU, FS)) { MCAsmParserExtension::Initialize(_Parser); // Initialize the set of available features. diff --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp index 5b66a059722..db6ab33ed68 100644 --- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -19,6 +19,7 @@ #include "llvm/MC/MCParser/MCAsmLexer.h" #include "llvm/MC/MCParser/MCAsmParser.h" #include "llvm/MC/MCParser/MCParsedAsmOperand.h" +#include "llvm/ADT/OwningPtr.h" #include "llvm/ADT/SmallString.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringExtras.h" @@ -37,7 +38,7 @@ struct X86Operand; class X86ATTAsmParser : public TargetAsmParser { MCAsmParser &Parser; - const MCSubtargetInfo *STI; + OwningPtr<const MCSubtargetInfo> STI; private: MCAsmParser &getParser() const { return Parser; } @@ -79,8 +80,8 @@ private: public: X86ATTAsmParser(StringRef TT, StringRef CPU, StringRef FS, MCAsmParser &parser) - : TargetAsmParser(), Parser(parser) { - STI = X86_MC::createX86MCSubtargetInfo(TT, CPU, FS); + : TargetAsmParser(), Parser(parser), + STI(X86_MC::createX86MCSubtargetInfo(TT, CPU, FS)) { // Initialize the set of available features. setAvailableFeatures(ComputeAvailableFeatures(STI->getFeatureBits())); |

