diff options
author | George Burgess IV <george.burgess.iv@gmail.com> | 2017-06-27 21:31:31 +0000 |
---|---|---|
committer | George Burgess IV <george.burgess.iv@gmail.com> | 2017-06-27 21:31:31 +0000 |
commit | d3cf025ae22188a15e8249a5c69bcf71aa4450e2 (patch) | |
tree | 49e6129dff948b59f8b519373ac4f52b5ca345c1 /llvm/lib | |
parent | 0b7688e6c0048cfcb9834c00d31b975eea30d849 (diff) | |
download | bcm5719-llvm-d3cf025ae22188a15e8249a5c69bcf71aa4450e2.tar.gz bcm5719-llvm-d3cf025ae22188a15e8249a5c69bcf71aa4450e2.zip |
[Sema] Allow unmarked overloadable functions.
This patch extends the `overloadable` attribute to allow for one
function with a given name to not be marked with the `overloadable`
attribute. The overload without the `overloadable` attribute will not
have its name mangled.
So, the following code is now legal:
void foo(void) __attribute__((overloadable));
void foo(int);
void foo(float) __attribute__((overloadable));
In addition, this patch fixes a bug where we'd accept code with
`__attribute__((overloadable))` inconsistently applied. In other words,
we used to accept:
void foo(void);
void foo(void) __attribute__((overloadable));
But we will do this no longer, since it defeats the original purpose of
requiring `__attribute__((overloadable))` on all redeclarations of a
function.
This breakage seems to not be an issue in practice, since the only code
I could find that had this pattern often looked like:
void foo(void);
void foo(void) __attribute__((overloadable)) __asm__("foo");
void foo(int) __attribute__((overloadable));
...Which can now be simplified by simply removing the asm label and
overloadable attribute from the redeclaration of `void foo(void);`
Differential Revision: https://reviews.llvm.org/D32332
llvm-svn: 306467
Diffstat (limited to 'llvm/lib')
0 files changed, 0 insertions, 0 deletions