diff options
author | Eric Fiselier <eric@efcs.ca> | 2016-11-14 07:26:17 +0000 |
---|---|---|
committer | Eric Fiselier <eric@efcs.ca> | 2016-11-14 07:26:17 +0000 |
commit | c79c9d8536b8d4f780afca4d0c2bbf5d4be6db3d (patch) | |
tree | 48cd341258676d8f65599997296fc69f92588d7e /llvm/lib | |
parent | e95fc44ce594c80af76883a0398630d1865dea12 (diff) | |
download | bcm5719-llvm-c79c9d8536b8d4f780afca4d0c2bbf5d4be6db3d.tar.gz bcm5719-llvm-c79c9d8536b8d4f780afca4d0c2bbf5d4be6db3d.zip |
Add explicit (void) cast to unused unique_ptr::release() results
Summary:
This patch adds explicit `(void)` casts to discarded `release()` calls to suppress -Wunused-result.
This patch fixes *all* warnings are generated as a result of [applying `[[nodiscard]]` within libc++](https://reviews.llvm.org/D26596).
Similar fixes were applied to Clang in r286796.
Reviewers: chandlerc, dberris
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D26598
llvm-svn: 286797
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Bitcode/Reader/BitReader.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Bitcode/Reader/BitReader.cpp b/llvm/lib/Bitcode/Reader/BitReader.cpp index 63854307b7b..f64785b3ad9 100644 --- a/llvm/lib/Bitcode/Reader/BitReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitReader.cpp @@ -84,7 +84,9 @@ LLVMBool LLVMGetBitcodeModuleInContext(LLVMContextRef ContextRef, std::unique_ptr<MemoryBuffer> Owner(unwrap(MemBuf)); Expected<std::unique_ptr<Module>> ModuleOrErr = getOwningLazyBitcodeModule(std::move(Owner), Ctx); - Owner.release(); + // Release the buffer if we didn't take ownership of it since we never owned + // it anyway. + (void)Owner.release(); if (Error Err = ModuleOrErr.takeError()) { std::string Message; |