diff options
| author | David Blaikie <dblaikie@gmail.com> | 2014-09-15 22:41:25 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2014-09-15 22:41:25 +0000 |
| commit | ba656e1d7c7f8d6ad6ecd6bf526b09771d3b7e9a (patch) | |
| tree | 70e1f25b225c1b9a49cd2c293e78ec823f246433 /llvm/lib | |
| parent | fbd703add593253cdea7f18fa0648844905b59a2 (diff) | |
| download | bcm5719-llvm-ba656e1d7c7f8d6ad6ecd6bf526b09771d3b7e9a.tar.gz bcm5719-llvm-ba656e1d7c7f8d6ad6ecd6bf526b09771d3b7e9a.zip | |
DebugInfo: Add comment describing the need to disable address pool usage in skeleton units.
Post commit review from Eric Christopher.
llvm-svn: 217842
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp index 4206ffd5535..4cd32f8668e 100644 --- a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp @@ -286,6 +286,11 @@ void DwarfUnit::addSectionOffset(DIE &Die, dwarf::Attribute Attribute, void DwarfCompileUnit::addLabelAddress(DIE &Die, dwarf::Attribute Attribute, const MCSymbol *Label) { + // Don't use the address pool in non-fission or in the skeleton unit itself. + // FIXME: Once GDB supports this, it's probably worthwhile using the address + // pool from the skeleton - maybe even in non-fission (possibly fewer + // relocations by sharing them in the pool, but we have other ideas about how + // to reduce the number of relocations as well/instead). if (!DD->useSplitDwarf() || !Skeleton) return addLocalLabelAddress(Die, Attribute, Label); |
