diff options
author | Eric Christopher <echristo@gmail.com> | 2017-03-30 22:34:20 +0000 |
---|---|---|
committer | Eric Christopher <echristo@gmail.com> | 2017-03-30 22:34:20 +0000 |
commit | b9c56d123521ffaaa83a8760b7f927d6f32486f6 (patch) | |
tree | d5e6643e1e4346a261c8036c10256d50fc130a40 /llvm/lib | |
parent | 79e5bc528d4666124ccb37a925ca62d80789e58b (diff) | |
download | bcm5719-llvm-b9c56d123521ffaaa83a8760b7f927d6f32486f6.tar.gz bcm5719-llvm-b9c56d123521ffaaa83a8760b7f927d6f32486f6.zip |
getPristineRegs is not accurately considering shrink wrapping puts
registers not saved in certain blocks. Use explicit getCalleeSavedInfo
and isLiveIn instead.
This fixes pr32292.
Patch by Tim Shen!
llvm-svn: 299124
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/AsmParser/LLParser.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp | 3 | ||||
-rw-r--r-- | llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp | 4 |
3 files changed, 8 insertions, 2 deletions
diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp index ab315dd2c7f..d8f6c1c5146 100644 --- a/llvm/lib/AsmParser/LLParser.cpp +++ b/llvm/lib/AsmParser/LLParser.cpp @@ -4593,6 +4593,9 @@ bool LLParser::parseConstantValue(Type *Ty, Constant *&C) { C = cast<Constant>(V); return false; } + case ValID::t_Null: + C = Constant::getNullValue(Ty); + return false; default: return Error(Loc, "expected a constant value"); } diff --git a/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp b/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp index a60a43a2ddc..955524c2a67 100644 --- a/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp +++ b/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp @@ -166,7 +166,8 @@ void AggressiveAntiDepBreaker::StartBlock(MachineBasicBlock *BB) { for (const MCPhysReg *I = MF.getRegInfo().getCalleeSavedRegs(); *I; ++I) { unsigned Reg = *I; - if (!IsReturnBlock && !Pristine.test(Reg)) continue; + if (!IsReturnBlock && !(Pristine.test(Reg) || BB->isLiveIn(Reg))) + continue; for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) { unsigned AliasReg = *AI; State->UnionGroups(AliasReg, 0); diff --git a/llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp b/llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp index 615d7eb7b4d..e1eeddf0816 100644 --- a/llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp +++ b/llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp @@ -73,7 +73,9 @@ void CriticalAntiDepBreaker::StartBlock(MachineBasicBlock *BB) { BitVector Pristine = MFI.getPristineRegs(MF); for (const MCPhysReg *I = MF.getRegInfo().getCalleeSavedRegs(); *I; ++I) { - if (!IsReturnBlock && !Pristine.test(*I)) continue; + unsigned Reg = *I; + if (!IsReturnBlock && !(Pristine.test(Reg) || BB->isLiveIn(Reg))) + continue; for (MCRegAliasIterator AI(*I, TRI, true); AI.isValid(); ++AI) { unsigned Reg = *AI; Classes[Reg] = reinterpret_cast<TargetRegisterClass *>(-1); |