summaryrefslogtreecommitdiffstats
path: root/llvm/lib
diff options
context:
space:
mode:
authorDiego Novillo <dnovillo@google.com>2014-06-18 18:46:58 +0000
committerDiego Novillo <dnovillo@google.com>2014-06-18 18:46:58 +0000
commitb2ad56effc6f8f9f62a6c5ec6647192d5522a1b8 (patch)
treef0da40f9c6ae7eb8f5a038a9d6a02b76e1a6344c /llvm/lib
parentf460d69ada1367a4877d2561b043c946c587f61e (diff)
downloadbcm5719-llvm-b2ad56effc6f8f9f62a6c5ec6647192d5522a1b8.tar.gz
bcm5719-llvm-b2ad56effc6f8f9f62a6c5ec6647192d5522a1b8.zip
Simply test for available locations in optimization remarks.
When emitting optimization remarks, we test for the presence of instruction locations by testing for a valid llvm.dbg.cu annotation. This is slightly inefficient because we can simply ask whether the debug location we have is known or not. Additionally, if my current plan works, I will need to remove the llvm.dbg.cu annotation from the IL (or prevent it from being generated) when -Rpass is used without -g. In those cases, we'll want to generate line tables but we will want to prevent code generation from emitting DWARF code for them. Tested on x86_64. llvm-svn: 211204
Diffstat (limited to 'llvm/lib')
-rw-r--r--llvm/lib/IR/DiagnosticInfo.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/IR/DiagnosticInfo.cpp b/llvm/lib/IR/DiagnosticInfo.cpp
index 6eeb16220ea..27270636004 100644
--- a/llvm/lib/IR/DiagnosticInfo.cpp
+++ b/llvm/lib/IR/DiagnosticInfo.cpp
@@ -128,7 +128,7 @@ void DiagnosticInfoSampleProfile::print(DiagnosticPrinter &DP) const {
}
bool DiagnosticInfoOptimizationRemarkBase::isLocationAvailable() const {
- return getFunction().getParent()->getNamedMetadata("llvm.dbg.cu") != nullptr;
+ return getDebugLoc().isUnknown() == false;
}
void DiagnosticInfoOptimizationRemarkBase::getLocation(StringRef *Filename,
OpenPOWER on IntegriCloud