diff options
author | Erik Pilkington <erik.pilkington@gmail.com> | 2019-11-04 10:47:44 -0800 |
---|---|---|
committer | Erik Pilkington <erik.pilkington@gmail.com> | 2019-11-04 12:17:12 -0800 |
commit | af11f417fc7d2390da4a883c05c098f23891862e (patch) | |
tree | e88c7b6b061b2d88095b80155fb1a0e2626203b8 /llvm/lib | |
parent | efad56b2be9b9f7d5b62d1f06541192fa6b537ee (diff) | |
download | bcm5719-llvm-af11f417fc7d2390da4a883c05c098f23891862e.tar.gz bcm5719-llvm-af11f417fc7d2390da4a883c05c098f23891862e.zip |
[demangle] NFC: get rid of NodeOrString
This class was a bit overengineered, and was triggering some PVS warnings.
Instead, put strings into a NameType and let clients unconditionally treat it
as a Node.
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Demangle/ItaniumDemangle.cpp | 8 | ||||
-rw-r--r-- | llvm/lib/Support/ItaniumManglingCanonicalizer.cpp | 11 |
2 files changed, 0 insertions, 19 deletions
diff --git a/llvm/lib/Demangle/ItaniumDemangle.cpp b/llvm/lib/Demangle/ItaniumDemangle.cpp index 760d28b3ab9..e112d5c5ec7 100644 --- a/llvm/lib/Demangle/ItaniumDemangle.cpp +++ b/llvm/lib/Demangle/ItaniumDemangle.cpp @@ -89,14 +89,6 @@ struct DumpVisitor { else printStr("<null>"); } - void print(NodeOrString NS) { - if (NS.isNode()) - print(NS.asNode()); - else if (NS.isString()) - print(NS.asString()); - else - printStr("NodeOrString()"); - } void print(NodeArray A) { ++Depth; printStr("{"); diff --git a/llvm/lib/Support/ItaniumManglingCanonicalizer.cpp b/llvm/lib/Support/ItaniumManglingCanonicalizer.cpp index da6514f7170..3db27c3f9ff 100644 --- a/llvm/lib/Support/ItaniumManglingCanonicalizer.cpp +++ b/llvm/lib/Support/ItaniumManglingCanonicalizer.cpp @@ -36,17 +36,6 @@ struct FoldingSetNodeIDBuilder { operator()(T V) { ID.AddInteger((unsigned long long)V); } - void operator()(itanium_demangle::NodeOrString NS) { - if (NS.isNode()) { - ID.AddInteger(0); - (*this)(NS.asNode()); - } else if (NS.isString()) { - ID.AddInteger(1); - (*this)(NS.asString()); - } else { - ID.AddInteger(2); - } - } void operator()(itanium_demangle::NodeArray A) { ID.AddInteger(A.size()); for (const Node *N : A) |