diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-06-07 18:05:03 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-06-07 18:05:03 +0000 |
commit | 8d477dc08fa6b5650d68f4025511178671ebbeea (patch) | |
tree | 8271846a28c3bc412be4c13f5997a54927b84e6a /llvm/lib | |
parent | a8d766d6fde3cf0cde92c28ccee6527fb0d35472 (diff) | |
download | bcm5719-llvm-8d477dc08fa6b5650d68f4025511178671ebbeea.tar.gz bcm5719-llvm-8d477dc08fa6b5650d68f4025511178671ebbeea.zip |
Use isxdigit.
Thanks to Benjamin Kramer for the suggestion.
llvm-svn: 183540
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Object/YAML.cpp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/llvm/lib/Object/YAML.cpp b/llvm/lib/Object/YAML.cpp index e63bd5df27c..4e7f0890989 100644 --- a/llvm/lib/Object/YAML.cpp +++ b/llvm/lib/Object/YAML.cpp @@ -23,14 +23,6 @@ void yaml::ScalarTraits<object::yaml::BinaryRef>::output( Val.writeAsHex(Out); } -// Can't find this anywhere else in the codebase (clang has one, but it has -// some baggage). Deduplicate as required. -static bool isHexDigit(uint8_t C) { - return ('0' <= C && C <= '9') || - ('A' <= C && C <= 'F') || - ('a' <= C && C <= 'f'); -} - StringRef yaml::ScalarTraits<object::yaml::BinaryRef>::input( StringRef Scalar, void *, object::yaml::BinaryRef &Val) { if (Scalar.size() % 2 != 0) @@ -38,7 +30,7 @@ StringRef yaml::ScalarTraits<object::yaml::BinaryRef>::input( // TODO: Can we improve YAMLIO to permit a more accurate diagnostic here? // (e.g. a caret pointing to the offending character). for (unsigned I = 0, N = Scalar.size(); I != N; ++I) - if (!isHexDigit(Scalar[I])) + if (!isxdigit(Scalar[I])) return "BinaryRef hex string must contain only hex digits."; Val = object::yaml::BinaryRef(Scalar); return StringRef(); |