diff options
| author | Bob Wilson <bob.wilson@apple.com> | 2012-08-07 22:35:16 +0000 |
|---|---|---|
| committer | Bob Wilson <bob.wilson@apple.com> | 2012-08-07 22:35:16 +0000 |
| commit | 61f3ad575911f72cbfcd328d1221e943b687ebf2 (patch) | |
| tree | dac10fc42a864c49fab0eae70a309d1ec6ed531c /llvm/lib | |
| parent | fbdd25c13576d68ad2517390513c7a0f23d93919 (diff) | |
| download | bcm5719-llvm-61f3ad575911f72cbfcd328d1221e943b687ebf2.tar.gz bcm5719-llvm-61f3ad575911f72cbfcd328d1221e943b687ebf2.zip | |
Fix a serious typo in InstCombine's optimization of comparisons.
An unsigned value converted to floating-point will always be greater than
a negative constant. Unfortunately InstCombine reversed the check so that
unsigned values were being optimized to always be greater than all positive
floating-point constants. <rdar://problem/12029145>
llvm-svn: 161452
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp index 7076d88554d..bdd310e97f6 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp @@ -2824,7 +2824,7 @@ Instruction *InstCombiner::FoldFCmp_IntToFP_Cst(FCmpInst &I, case ICmpInst::ICMP_UGE: // (float)int >= -4.4 --> true // (float)int >= 4.4 --> int > 4 - if (!RHS.isNegative()) + if (RHS.isNegative()) return ReplaceInstUsesWith(I, ConstantInt::getTrue(I.getContext())); Pred = ICmpInst::ICMP_UGT; break; |
