diff options
author | Marcos Pividori <mpividori@google.com> | 2017-02-08 00:03:31 +0000 |
---|---|---|
committer | Marcos Pividori <mpividori@google.com> | 2017-02-08 00:03:31 +0000 |
commit | 5a53567620545b995d2c26f12431c8e575dea802 (patch) | |
tree | 9663312a43f514bea8d83068c38f041315f3f0b6 /llvm/lib | |
parent | 2a318a18dbf5d550fe5d9fa5608eb25961f4849d (diff) | |
download | bcm5719-llvm-5a53567620545b995d2c26f12431c8e575dea802.tar.gz bcm5719-llvm-5a53567620545b995d2c26f12431c8e575dea802.zip |
[libFuzzer] Use long long to ensure 64 bits.
We should always use unsigned long long to ensure 64 bits. On Windows, unsigned
long is 4 bytes. This was the reason why value-profile-cmp4.test was failing on
Windows.
Differential Revision: https://reviews.llvm.org/D29617
llvm-svn: 294390
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Fuzzer/FuzzerTracePC.cpp | 2 | ||||
-rw-r--r-- | llvm/lib/Fuzzer/FuzzerValueBitMap.h | 2 | ||||
-rw-r--r-- | llvm/lib/Fuzzer/test/AbsNegAndConstant64Test.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/llvm/lib/Fuzzer/FuzzerTracePC.cpp b/llvm/lib/Fuzzer/FuzzerTracePC.cpp index ff1d494bafe..661ad23a8e3 100644 --- a/llvm/lib/Fuzzer/FuzzerTracePC.cpp +++ b/llvm/lib/Fuzzer/FuzzerTracePC.cpp @@ -273,7 +273,7 @@ ATTRIBUTE_TARGET_POPCNT ALWAYS_INLINE ATTRIBUTE_NO_SANITIZE_ALL void TracePC::HandleCmp(uintptr_t PC, T Arg1, T Arg2) { uint64_t ArgXor = Arg1 ^ Arg2; - uint64_t ArgDistance = __builtin_popcountl(ArgXor) + 1; // [1,65] + uint64_t ArgDistance = __builtin_popcountll(ArgXor) + 1; // [1,65] uintptr_t Idx = ((PC & 4095) + 1) * ArgDistance; if (sizeof(T) == 4) TORC4.Insert(ArgXor, Arg1, Arg2); diff --git a/llvm/lib/Fuzzer/FuzzerValueBitMap.h b/llvm/lib/Fuzzer/FuzzerValueBitMap.h index 68dc3a9fc3a..600337ae407 100644 --- a/llvm/lib/Fuzzer/FuzzerValueBitMap.h +++ b/llvm/lib/Fuzzer/FuzzerValueBitMap.h @@ -68,7 +68,7 @@ struct ValueBitMap { Other.Map[i] = 0; } if (M) - Res += __builtin_popcountl(M); + Res += __builtin_popcountll(M); } NumBits = Res; return OldNumBits < NumBits; diff --git a/llvm/lib/Fuzzer/test/AbsNegAndConstant64Test.cpp b/llvm/lib/Fuzzer/test/AbsNegAndConstant64Test.cpp index 577481431ae..69b0d59fb8e 100644 --- a/llvm/lib/Fuzzer/test/AbsNegAndConstant64Test.cpp +++ b/llvm/lib/Fuzzer/test/AbsNegAndConstant64Test.cpp @@ -14,7 +14,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) { uint64_t y; memcpy(&x, Data, sizeof(x)); memcpy(&y, Data + sizeof(x), sizeof(y)); - if (labs(x) < 0 && y == 0xbaddcafedeadbeefUL) { + if (llabs(x) < 0 && y == 0xbaddcafedeadbeefULL) { printf("BINGO; Found the target, exiting; x = 0x%lx y 0x%lx\n", x, y); exit(1); } |