diff options
author | David Tweed <david.tweed@arm.com> | 2013-03-18 11:54:44 +0000 |
---|---|---|
committer | David Tweed <david.tweed@arm.com> | 2013-03-18 11:54:44 +0000 |
commit | 5493feed251b00413a1978fc13a4a00fb7ec4e9e (patch) | |
tree | c6c781fb550580e30f1520361909c0a13bb31a2a /llvm/lib | |
parent | 15bee188c4c141c3f82a86df3c3f4eba172c1706 (diff) | |
download | bcm5719-llvm-5493feed251b00413a1978fc13a4a00fb7ec4e9e.tar.gz bcm5719-llvm-5493feed251b00413a1978fc13a4a00fb7ec4e9e.zip |
The optimization a + (-0.0f) -> a was being misapplied to a + (+0.0f) in the vector case (because
we weren't differntiating floating-point zeroinitializers from other zero-initializers)
which was causing problems for code relying upon a + (+0.0f) to, eg, flush denormals to
0. Make the scalar and vector cases have the same behaviour.
llvm-svn: 177279
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/IR/Constants.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/llvm/lib/IR/Constants.cpp b/llvm/lib/IR/Constants.cpp index 0c7effb5cac..70f7e0176e8 100644 --- a/llvm/lib/IR/Constants.cpp +++ b/llvm/lib/IR/Constants.cpp @@ -47,6 +47,19 @@ bool Constant::isNegativeZeroValue() const { if (const ConstantFP *CFP = dyn_cast<ConstantFP>(this)) return CFP->isZero() && CFP->isNegative(); + // Equivalent for a vector of -0.0's. + if (const ConstantDataVector *CV = dyn_cast<ConstantDataVector>(this)) + if (ConstantFP *SplatCFP = dyn_cast_or_null<ConstantFP>(CV->getSplatValue())) + if (SplatCFP && SplatCFP->isZero() && SplatCFP->isNegative()) + return true; + + // However, vectors of zeroes which are floating point represent +0.0's. + if (const ConstantAggregateZero *CAZ = dyn_cast<ConstantAggregateZero>(this)) + if (const VectorType *VT = dyn_cast<VectorType>(CAZ->getType())) + if (VT->getElementType()->isFloatingPointTy()) + // As it's a CAZ, we know it's the zero bit-pattern (ie, +0.0) in each element. + return false; + // Otherwise, just use +0.0. return isNullValue(); } |