summaryrefslogtreecommitdiffstats
path: root/llvm/lib
diff options
context:
space:
mode:
authorChandler Carruth <chandlerc@gmail.com>2016-12-24 05:11:17 +0000
committerChandler Carruth <chandlerc@gmail.com>2016-12-24 05:11:17 +0000
commit534d644b869562791a1781c3182ec08557485b0e (patch)
treede20edc641a3cc72a81ac0b03922de297ba9bd73 /llvm/lib
parent47570b8d2cd4c9babdd2928ae7ee1ce871cda3f6 (diff)
downloadbcm5719-llvm-534d644b869562791a1781c3182ec08557485b0e.tar.gz
bcm5719-llvm-534d644b869562791a1781c3182ec08557485b0e.zip
[PM] Try to improve the comments here to make what's going on more
clear. Based on post-commit review suggestion from Sean. (Thanks!) llvm-svn: 290488
Diffstat (limited to 'llvm/lib')
-rw-r--r--llvm/lib/Passes/PassBuilder.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/llvm/lib/Passes/PassBuilder.cpp b/llvm/lib/Passes/PassBuilder.cpp
index b7609c994cf..221ee15a78e 100644
--- a/llvm/lib/Passes/PassBuilder.cpp
+++ b/llvm/lib/Passes/PassBuilder.cpp
@@ -561,10 +561,12 @@ AAManager PassBuilder::buildDefaultAAPipeline() {
AA.registerFunctionAnalysis<TypeBasedAA>();
// Add support for querying global aliasing information when available.
- // Because this is a module analysis this will use any cached analysis state
- // available but isn't enough to cause it to be available.
- // FIXME: Enable once the invalidation logic supports this.
+ // Because the `AAManager` is a function analysis and `GlobalsAA` is a module
+ // analysis, all that the `AAManager` can do is query for any *cached*
+ // results from `GlobalsAA` through a readonly proxy..
#if 0
+ // FIXME: Enable once the invalidation logic supports this. Currently, the
+ // `AAManager` will hold stale references to the module analyses.
AA.registerModuleAnalysis<GlobalsAA>();
#endif
OpenPOWER on IntegriCloud