diff options
author | Alex Bradbury <asb@lowrisc.org> | 2019-03-11 21:41:22 +0000 |
---|---|---|
committer | Alex Bradbury <asb@lowrisc.org> | 2019-03-11 21:41:22 +0000 |
commit | 4d20cc21c774ca9abd19e3d96b909c928775f78a (patch) | |
tree | 34520cf9832f47a538771f30b6cdb15a51efd557 /llvm/lib | |
parent | 93f8cc186ace5965a826dd2a11a359f661ba75a3 (diff) | |
download | bcm5719-llvm-4d20cc21c774ca9abd19e3d96b909c928775f78a.tar.gz bcm5719-llvm-4d20cc21c774ca9abd19e3d96b909c928775f78a.zip |
[RISCV] Do a sign-extension in a compare-and-swap of 32 bit in RV64A
AtomicCmpSwapWithSuccess is legalised into an AtomicCmpSwap plus a comparison.
This requires an extension of the value which, by default, is a
zero-extension. When we later lower AtomicCmpSwap into a PseudoCmpXchg32 and then expanded in
RISCVExpandPseudoInsts.cpp, the lr.w instruction does a sign-extension.
This mismatch of extensions causes the comparison to fail when the compared
value is negative. This change overrides TargetLowering::getExtendForAtomicOps
for RISC-V so it does a sign-extension instead.
Differential Revision: https://reviews.llvm.org/D58829
Patch by Ferran Pallarès Roca.
llvm-svn: 355869
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Target/RISCV/RISCVISelLowering.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.h b/llvm/lib/Target/RISCV/RISCVISelLowering.h index 4c9fd26e5cf..fc6968202f4 100644 --- a/llvm/lib/Target/RISCV/RISCVISelLowering.h +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.h @@ -106,6 +106,10 @@ public: Instruction *emitTrailingFence(IRBuilder<> &Builder, Instruction *Inst, AtomicOrdering Ord) const override; + ISD::NodeType getExtendForAtomicOps() const override { + return ISD::SIGN_EXTEND; + } + private: void analyzeInputArgs(MachineFunction &MF, CCState &CCInfo, const SmallVectorImpl<ISD::InputArg> &Ins, |