diff options
| author | Craig Topper <craig.topper@intel.com> | 2017-12-26 22:22:58 +0000 |
|---|---|---|
| committer | Craig Topper <craig.topper@intel.com> | 2017-12-26 22:22:58 +0000 |
| commit | 428d87e55921f93ff498f7a6fb26760106024216 (patch) | |
| tree | 93c0bf558f5e6881158e81f3e826d442cf9e6936 /llvm/lib | |
| parent | 8d8a7da7450ca9ab9a4e0ea529dd6b720d0b0d56 (diff) | |
| download | bcm5719-llvm-428d87e55921f93ff498f7a6fb26760106024216.tar.gz bcm5719-llvm-428d87e55921f93ff498f7a6fb26760106024216.zip | |
[X86] Return SDValue(N, 0) instead of an SDValue() after a successful combine.
Returning SDValue() means nothing changed, SDValue(N,0) means there was a change but the worklist management was taken care of.
I don't know if this has a real effect other than making sure the combine counter in the DAG combiner gets updated, but it is the correct thing to do.
llvm-svn: 321463
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Target/X86/X86ISelLowering.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 321bc0e36eb..ae5100e9bb4 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -31003,8 +31003,8 @@ static SDValue combineExtractVectorElt(SDNode *N, SelectionDAG &DAG, DAG.ReplaceAllUsesOfValueWith(SDValue(Extract, 0), Vals[IdxVal]); } - // The replacement was made in place; don't return anything. - return SDValue(); + // The replacement was made in place; return N so it won't be revisited. + return SDValue(N, 0); } /// If a vector select has an operand that is -1 or 0, try to simplify the |
