summaryrefslogtreecommitdiffstats
path: root/llvm/lib
diff options
context:
space:
mode:
authorDan Gohman <gohman@apple.com>2009-09-07 23:47:14 +0000
committerDan Gohman <gohman@apple.com>2009-09-07 23:47:14 +0000
commit2512a425481e02b21b2e412239c9fe70d9ff77fe (patch)
treef8944e7c5b0b682ef9249135a69fe97ae8609b2e /llvm/lib
parenta34a718c4bcaa6f266ccfc3b9f80a717be4f77b2 (diff)
downloadbcm5719-llvm-2512a425481e02b21b2e412239c9fe70d9ff77fe.tar.gz
bcm5719-llvm-2512a425481e02b21b2e412239c9fe70d9ff77fe.zip
Fix a thinko: When lowering fneg with xor, bitcast the operands
from floating-point to integer first, and bitcast the result back to floating-point. Previously, this test was passing by falling back to SelectionDAG lowering. The resulting code isn't as nice, but it's correct and CodeGen now stays on the fast path. llvm-svn: 81171
Diffstat (limited to 'llvm/lib')
-rw-r--r--llvm/lib/CodeGen/SelectionDAG/FastISel.cpp21
1 files changed, 17 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp b/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
index f0c70861843..8550ea9813d 100644
--- a/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
@@ -615,12 +615,25 @@ FastISel::SelectFNeg(User *I) {
unsigned OpReg = getRegForValue(BinaryOperator::getFNegArgument(I));
if (OpReg == 0) return false;
- // Twiddle the sign bit with xor.
+ // Bitcast the value to integer, twiddle the sign bit with xor,
+ // and then bitcast it back to floating-point.
EVT VT = TLI.getValueType(I->getType());
if (VT.getSizeInBits() > 64) return false;
- unsigned ResultReg = FastEmit_ri_(VT.getSimpleVT(), ISD::XOR, OpReg,
- UINT64_C(1) << (VT.getSizeInBits()-1),
- VT.getSimpleVT());
+ EVT IntVT = EVT::getIntegerVT(I->getContext(), VT.getSizeInBits());
+
+ unsigned IntReg = FastEmit_r(VT.getSimpleVT(), IntVT.getSimpleVT(),
+ ISD::BIT_CONVERT, OpReg);
+ if (IntReg == 0)
+ return false;
+
+ unsigned IntResultReg = FastEmit_ri_(IntVT.getSimpleVT(), ISD::XOR, IntReg,
+ UINT64_C(1) << (VT.getSizeInBits()-1),
+ IntVT.getSimpleVT());
+ if (IntResultReg == 0)
+ return false;
+
+ unsigned ResultReg = FastEmit_r(IntVT.getSimpleVT(), VT.getSimpleVT(),
+ ISD::BIT_CONVERT, IntResultReg);
if (ResultReg == 0)
return false;
OpenPOWER on IntegriCloud