summaryrefslogtreecommitdiffstats
path: root/llvm/lib
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2009-07-18 18:49:04 +0000
committerChris Lattner <sabre@nondot.org>2009-07-18 18:49:04 +0000
commit1c71fd646b603f3d2de4280f02f3db593bfb2942 (patch)
treed18dbd46e7d628dc21298ec61ca7ce0613200e4e /llvm/lib
parent858702541dfbdcd72f8e26bf6e2eae2d4582ebb5 (diff)
downloadbcm5719-llvm-1c71fd646b603f3d2de4280f02f3db593bfb2942.tar.gz
bcm5719-llvm-1c71fd646b603f3d2de4280f02f3db593bfb2942.zip
add a fixme
llvm-svn: 76324
Diffstat (limited to 'llvm/lib')
-rw-r--r--llvm/lib/Transforms/Utils/InlineCost.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/Utils/InlineCost.cpp b/llvm/lib/Transforms/Utils/InlineCost.cpp
index 5fe85e6ef29..8925a752b19 100644
--- a/llvm/lib/Transforms/Utils/InlineCost.cpp
+++ b/llvm/lib/Transforms/Utils/InlineCost.cpp
@@ -45,6 +45,11 @@ unsigned InlineCostAnalyzer::FunctionInfo::
// We can't constant propagate instructions which have effects or
// read memory.
+ //
+ // FIXME: It would be nice to capture the fact that a load from a
+ // pointer-to-constant-global is actually a *really* good thing to zap.
+ // Unfortunately, we don't know the pointer that may get propagated here,
+ // so we can't make this decision.
if (Inst.mayReadFromMemory() || Inst.mayHaveSideEffects() ||
isa<AllocationInst>(Inst))
continue;
OpenPOWER on IntegriCloud