diff options
| author | Philip Reames <listmail@philipreames.com> | 2018-08-29 22:09:21 +0000 |
|---|---|---|
| committer | Philip Reames <listmail@philipreames.com> | 2018-08-29 22:09:21 +0000 |
| commit | 1887c40b22e58d17c088f4bea35acc22d3bbc664 (patch) | |
| tree | bff46a19d34fb93d37617f2ec5669892b9d3e7b7 /llvm/lib | |
| parent | ed19831f63223b9540862ccc3c6d185014b5f6b7 (diff) | |
| download | bcm5719-llvm-1887c40b22e58d17c088f4bea35acc22d3bbc664.tar.gz bcm5719-llvm-1887c40b22e58d17c088f4bea35acc22d3bbc664.zip | |
Add a todo and tests to Address a review commnt from D50925 [NFC]
llvm-svn: 340978
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Transforms/Scalar/LICM.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/LICM.cpp b/llvm/lib/Transforms/Scalar/LICM.cpp index ff7cb3c26c9..470ae3e447e 100644 --- a/llvm/lib/Transforms/Scalar/LICM.cpp +++ b/llvm/lib/Transforms/Scalar/LICM.cpp @@ -737,7 +737,9 @@ bool llvm::canSinkOrHoistInst(Instruction &I, AAResults *AA, DominatorTree *DT, // We can only hoist a store that we can prove writes a value which is not // read or overwritten within the loop. For those cases, we fallback to - // load store promotion instead. + // load store promotion instead. TODO: We can extend this to cases where + // there is exactly one write to the location and that write dominates an + // arbitrary number of reads in the loop. auto &AS = CurAST->getAliasSetFor(MemoryLocation::get(SI)); if (AS.isRef() || !AS.isMustAlias()) |

