diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2017-10-10 20:00:07 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2017-10-10 20:00:07 +0000 |
| commit | 12db383e20c7585c33a5e12e8e56e01a065d7dab (patch) | |
| tree | ed6038dc5392844b8e067d9b3629a67d53e9c21d /llvm/lib | |
| parent | de4b88d9a1b961048864a17123b7a36974dc2b0d (diff) | |
| download | bcm5719-llvm-12db383e20c7585c33a5e12e8e56e01a065d7dab.tar.gz bcm5719-llvm-12db383e20c7585c33a5e12e8e56e01a065d7dab.zip | |
Convert two uses of ErrorOr to Expected.
llvm-svn: 315354
Diffstat (limited to 'llvm/lib')
| -rw-r--r-- | llvm/lib/Object/COFFObjectFile.cpp | 4 | ||||
| -rw-r--r-- | llvm/lib/Object/ELFObjectFile.cpp | 12 | ||||
| -rw-r--r-- | llvm/lib/Object/ObjectFile.cpp | 4 |
3 files changed, 10 insertions, 10 deletions
diff --git a/llvm/lib/Object/COFFObjectFile.cpp b/llvm/lib/Object/COFFObjectFile.cpp index f88ebfc9a1d..e139f64db6b 100644 --- a/llvm/lib/Object/COFFObjectFile.cpp +++ b/llvm/lib/Object/COFFObjectFile.cpp @@ -1590,12 +1590,12 @@ std::error_code ImportedSymbolRef::getOrdinal(uint16_t &Result) const { return std::error_code(); } -ErrorOr<std::unique_ptr<COFFObjectFile>> +Expected<std::unique_ptr<COFFObjectFile>> ObjectFile::createCOFFObjectFile(MemoryBufferRef Object) { std::error_code EC; std::unique_ptr<COFFObjectFile> Ret(new COFFObjectFile(Object, EC)); if (EC) - return EC; + return errorCodeToError(EC); return std::move(Ret); } diff --git a/llvm/lib/Object/ELFObjectFile.cpp b/llvm/lib/Object/ELFObjectFile.cpp index 986eccc36e3..da87b3b8c89 100644 --- a/llvm/lib/Object/ELFObjectFile.cpp +++ b/llvm/lib/Object/ELFObjectFile.cpp @@ -37,7 +37,7 @@ using namespace object; ELFObjectFileBase::ELFObjectFileBase(unsigned int Type, MemoryBufferRef Source) : ObjectFile(Type, Source) {} -ErrorOr<std::unique_ptr<ObjectFile>> +Expected<std::unique_ptr<ObjectFile>> ObjectFile::createELFObjectFile(MemoryBufferRef Obj) { std::pair<unsigned char, unsigned char> Ident = getElfArchType(Obj.getBuffer()); @@ -45,7 +45,7 @@ ObjectFile::createELFObjectFile(MemoryBufferRef Obj) { 1ULL << countTrailingZeros(uintptr_t(Obj.getBufferStart())); if (MaxAlignment < 2) - return object_error::parse_failed; + return createError("Insufficient alignment"); std::error_code EC; std::unique_ptr<ObjectFile> R; @@ -55,20 +55,20 @@ ObjectFile::createELFObjectFile(MemoryBufferRef Obj) { else if (Ident.second == ELF::ELFDATA2MSB) R.reset(new ELFObjectFile<ELFType<support::big, false>>(Obj, EC)); else - return object_error::parse_failed; + return createError("Invalid ELF data"); } else if (Ident.first == ELF::ELFCLASS64) { if (Ident.second == ELF::ELFDATA2LSB) R.reset(new ELFObjectFile<ELFType<support::little, true>>(Obj, EC)); else if (Ident.second == ELF::ELFDATA2MSB) R.reset(new ELFObjectFile<ELFType<support::big, true>>(Obj, EC)); else - return object_error::parse_failed; + return createError("Invalid ELF data"); } else { - return object_error::parse_failed; + return createError("Invalid ELF class"); } if (EC) - return EC; + return errorCodeToError(EC); return std::move(R); } diff --git a/llvm/lib/Object/ObjectFile.cpp b/llvm/lib/Object/ObjectFile.cpp index 2b80d0bf538..652a2b2497e 100644 --- a/llvm/lib/Object/ObjectFile.cpp +++ b/llvm/lib/Object/ObjectFile.cpp @@ -125,7 +125,7 @@ ObjectFile::createObjectFile(MemoryBufferRef Object, file_magic Type) { case file_magic::elf_executable: case file_magic::elf_shared_object: case file_magic::elf_core: - return errorOrToExpected(createELFObjectFile(Object)); + return createELFObjectFile(Object); case file_magic::macho_object: case file_magic::macho_executable: case file_magic::macho_fixed_virtual_memory_shared_lib: @@ -141,7 +141,7 @@ ObjectFile::createObjectFile(MemoryBufferRef Object, file_magic Type) { case file_magic::coff_object: case file_magic::coff_import_library: case file_magic::pecoff_executable: - return errorOrToExpected(createCOFFObjectFile(Object)); + return createCOFFObjectFile(Object); case file_magic::wasm_object: return createWasmObjectFile(Object); } |

