Def here is an Instruction, so !isa<Instruction>(Def) is always false,

as Eli noticed.

llvm-svn: 154641

1 files changed, 2 insertions, 3 deletions

diff --git a/llvm/lib/VMCore/Dominators.cpp b/llvm/lib/VMCore/Dominators.cpp
index b79688b31cd..219e6315cf4 100644
--- a/llvm/lib/VMCore/Dominators.cpp
+++ b/llvm/lib/VMCore/Dominators.cpp
@@ -189,10 +189,9 @@ bool DominatorTree::dominates(const Instruction *Def,
                               const Use &U) const {
   Instruction *UserInst = dyn_cast<Instruction>(U.getUser());
 
-  // All non-instructions conceptually dominate everything. Instructions do
-  // not dominate non-instructions.
+  // Instructions do not dominate non-instructions.
   if (!UserInst)
-    return !isa<Instruction>(Def);
+    return false;
 
   const BasicBlock *DefBB = Def->getParent();