summaryrefslogtreecommitdiffstats
path: root/llvm/lib/VMCore/AsmWriter.cpp
diff options
context:
space:
mode:
authorOwen Anderson <resistor@mac.com>2010-09-25 05:26:18 +0000
committerOwen Anderson <resistor@mac.com>2010-09-25 05:26:18 +0000
commitb590a927cd56d353b50834b3596e50bf760d0bb6 (patch)
tree0c84d25e7ca46204a8f960ede5c4f7667f1f5597 /llvm/lib/VMCore/AsmWriter.cpp
parent48cc21620f82ba2bade6704004c036cbae386086 (diff)
downloadbcm5719-llvm-b590a927cd56d353b50834b3596e50bf760d0bb6.tar.gz
bcm5719-llvm-b590a927cd56d353b50834b3596e50bf760d0bb6.zip
LoadPRE was not properly checking that the load it was PRE'ing post-dominated the block it was being hoisted to.
Splitting critical edges at the merge point only addressed part of the issue; it is also possible for non-post-domination to occur when the path from the load to the merge has branches in it. Unfortunately, full anticipation analysis is time-consuming, so for now approximate it. This is strictly more conservative than real anticipation, so we will miss some cases that real PRE would allow, but we also no longer insert loads into paths where they didn't exist before. :-) This is a very slight net positive on SPEC for me (0.5% on average). Most of the benchmarks are largely unaffected, but when it pays off it pays off decently: 181.mcf improves by 4.5% on my machine. llvm-svn: 114785
Diffstat (limited to 'llvm/lib/VMCore/AsmWriter.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud