diff options
| author | Bill Wendling <isanbard@gmail.com> | 2019-08-14 16:44:07 +0000 |
|---|---|---|
| committer | Bill Wendling <isanbard@gmail.com> | 2019-08-14 16:44:07 +0000 |
| commit | cc2bebe039374d6f0c8251ac322f8f7148d85950 (patch) | |
| tree | d1fbfc51dc0fb1fac3378161e56ad3d58c37668c /llvm/lib/Transforms | |
| parent | 86649980464ef799a7cec900c8b11dd2a7c15a15 (diff) | |
| download | bcm5719-llvm-cc2bebe039374d6f0c8251ac322f8f7148d85950.tar.gz bcm5719-llvm-cc2bebe039374d6f0c8251ac322f8f7148d85950.zip | |
Ignore indirect branches from callbr.
Summary:
We can't speculate around indirect branches: indirectbr and invoke. The
callbr instruction needs to be included here.
Reviewers: nickdesaulniers, manojgupta, chandlerc
Reviewed By: chandlerc
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66200
llvm-svn: 368873
Diffstat (limited to 'llvm/lib/Transforms')
| -rw-r--r-- | llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp b/llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp index c13fb3e0451..e6db11f47ea 100644 --- a/llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp +++ b/llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp @@ -777,8 +777,10 @@ static bool tryToSpeculatePHIs(SmallVectorImpl<PHINode *> &PNs, // speculation if the predecessor is an invoke. This doesn't seem // fundamental and we should probably be splitting critical edges // differently. - if (isa<IndirectBrInst>(PredBB->getTerminator()) || - isa<InvokeInst>(PredBB->getTerminator())) { + const auto *TermInst = PredBB->getTerminator(); + if (isa<IndirectBrInst>(TermInst) || + isa<InvokeInst>(TermInst) || + isa<CallBrInst>(TermInst)) { LLVM_DEBUG(dbgs() << " Invalid: predecessor terminator: " << PredBB->getName() << "\n"); return false; |

