summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms
diff options
context:
space:
mode:
authorJohannes Doerfert <doerfert@cs.uni-saarland.de>2018-09-11 11:51:29 +0000
committerJohannes Doerfert <doerfert@cs.uni-saarland.de>2018-09-11 11:51:29 +0000
commitae3cfeb3ad0e4d3d8846d83c4b75e2933f043800 (patch)
treefffad3bbd776614ad61cf784350e56e88970e1c1 /llvm/lib/Transforms
parenta58e9214ac6adc67e1a9229c7e8cea04819547a6 (diff)
downloadbcm5719-llvm-ae3cfeb3ad0e4d3d8846d83c4b75e2933f043800.tar.gz
bcm5719-llvm-ae3cfeb3ad0e4d3d8846d83c4b75e2933f043800.zip
[FuncAttrs] Remove "access range attributes" for read-none functions
The presence of readnone and an access range attribute (argmemonly, inaccessiblememonly, inaccessiblemem_or_argmemonly) is considered an error by the verifier. This seems strict but also not wrong. This patch makes sure function attribute detection will remove all access range attributes for readnone functions. llvm-svn: 341927
Diffstat (limited to 'llvm/lib/Transforms')
-rw-r--r--llvm/lib/Transforms/IPO/FunctionAttrs.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/IPO/FunctionAttrs.cpp b/llvm/lib/Transforms/IPO/FunctionAttrs.cpp
index d40ee30f453..72c850fca99 100644
--- a/llvm/lib/Transforms/IPO/FunctionAttrs.cpp
+++ b/llvm/lib/Transforms/IPO/FunctionAttrs.cpp
@@ -281,6 +281,13 @@ static bool addReadAttrs(const SCCNodeSet &SCCNodes, AARGetterT &&AARGetter) {
F->removeFnAttr(Attribute::ReadNone);
F->removeFnAttr(Attribute::WriteOnly);
+ if (!WritesMemory && !ReadsMemory) {
+ // Clear out any "access range attributes" if readnone was deduced.
+ F->removeFnAttr(Attribute::ArgMemOnly);
+ F->removeFnAttr(Attribute::InaccessibleMemOnly);
+ F->removeFnAttr(Attribute::InaccessibleMemOrArgMemOnly);
+ }
+
// Add in the new attribute.
if (WritesMemory && !ReadsMemory)
F->addFnAttr(Attribute::WriteOnly);
OpenPOWER on IntegriCloud