diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2016-03-15 14:18:26 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2016-03-15 14:18:26 +0000 |
| commit | 96f4b128800cc567a4355025963ea64caa750904 (patch) | |
| tree | f9d9436f17ed98c292e9c845cde763fe8fa6ac5d /llvm/lib/Transforms | |
| parent | ca1d1fb2d6e42c805a92cf630a8eabc9739c0964 (diff) | |
| download | bcm5719-llvm-96f4b128800cc567a4355025963ea64caa750904.tar.gz bcm5719-llvm-96f4b128800cc567a4355025963ea64caa750904.zip | |
[GlobalOpt] Don't look through aliases when sorting names of globals.
If both are different aliases to the same value the sorting becomes
non-deterministic as array_pod_sort is not stable.
llvm-svn: 263550
Diffstat (limited to 'llvm/lib/Transforms')
| -rw-r--r-- | llvm/lib/Transforms/IPO/GlobalOpt.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp index b9cef720a13..f6458f50696 100644 --- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp +++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp @@ -2199,8 +2199,9 @@ static bool EvaluateStaticConstructor(Function *F, const DataLayout &DL, } static int compareNames(Constant *const *A, Constant *const *B) { - return (*A)->stripPointerCasts()->getName().compare( - (*B)->stripPointerCasts()->getName()); + Value *AStripped = (*A)->stripPointerCastsNoFollowAliases(); + Value *BStripped = (*B)->stripPointerCastsNoFollowAliases(); + return AStripped->getName().compare(BStripped->getName()); } static void setUsedInitializer(GlobalVariable &V, |

