diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-10-23 11:51:53 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-10-23 11:51:53 +0000 |
| commit | 71891129510bffa27c5cd345135483db4522b3a2 (patch) | |
| tree | a385d9b0a83504b80d340301b84d8408e1d45646 /llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | |
| parent | 98b5f6d1596d17e5e6c7def7cf218da71dbefd85 (diff) | |
| download | bcm5719-llvm-71891129510bffa27c5cd345135483db4522b3a2.tar.gz bcm5719-llvm-71891129510bffa27c5cd345135483db4522b3a2.zip | |
Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document
Summary:
See http://lists.llvm.org/pipermail/clangd-dev/2018-October/000171.html for context.
I kept the error (instead of downgrading to a log message) since the range lengths differing does indicate either a bug in the client or server range calculation or the buffers being out of sync (which both seems serious enough to me to be an error). If any existing clients aside from VSCode break they should only break when accidentally typing a Unicode character which should only be a minor nuisance for a little while until the bug is fixed in the respective client.
Patch by Daan De Meyer!
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D53527
llvm-svn: 345020
Diffstat (limited to 'llvm/lib/Transforms/Vectorize/LoopVectorize.cpp')
0 files changed, 0 insertions, 0 deletions
