diff options
author | Krasimir Georgiev <krasimir@google.com> | 2019-09-17 14:15:23 +0000 |
---|---|---|
committer | Krasimir Georgiev <krasimir@google.com> | 2019-09-17 14:15:23 +0000 |
commit | bdff164e0e07224948244ddc9bce5fd7052e09b9 (patch) | |
tree | 6eedba88f906e633f1604f26b41b2db1be8c3247 /llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp | |
parent | 68b0977e646abda3254a1eed123f75183b4aad3d (diff) | |
download | bcm5719-llvm-bdff164e0e07224948244ddc9bce5fd7052e09b9.tar.gz bcm5719-llvm-bdff164e0e07224948244ddc9bce5fd7052e09b9.zip |
Revert "[SLC] Preserve attrs for strncpy(x, "", y) -> memset(align 1 x, '\0', y)"
Summary:
This reverts commit r372101.
Causes ASAN build bot failures:
http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176
From http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/14176/steps/64-bit%20check-asan/logs/stdio:
```
[ RUN ] AddressSanitizer.StrNCatOOBTest
/home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm-project/compiler-rt/lib/asan/tests/asan_str_test.cpp:462: Failure
Death test: strncat(to - 1, from, 0)
Result: failed to die.
```
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67658
llvm-svn: 372125
Diffstat (limited to 'llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp')
-rw-r--r-- | llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp index a5e31f21166..217f929e9ad 100644 --- a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp +++ b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp @@ -610,10 +610,7 @@ Value *LibCallSimplifier::optimizeStrNCpy(CallInst *CI, IRBuilder<> &B) { if (SrcLen == 0) { // strncpy(x, "", y) -> memset(align 1 x, '\0', y) - CallInst *NewCI = B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1); - AttrBuilder ArgAttrs(CI->getAttributes().getParamAttributes(0)); - NewCI->setAttributes(NewCI->getAttributes().addParamAttributes( - CI->getContext(), 0, ArgAttrs)); + B.CreateMemSet(Dst, B.getInt8('\0'), Size, 1); return Dst; } |