summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp
diff options
context:
space:
mode:
authorMax Kazantsev <max.kazantsev@azul.com>2018-04-23 10:32:37 +0000
committerMax Kazantsev <max.kazantsev@azul.com>2018-04-23 10:32:37 +0000
commitb1137c42fa9173e60c4396e1607205785c35bbe7 (patch)
tree02d7ad693def478eb876d8a2db38676dea54a774 /llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp
parent4a4e7a31adbc1fb69383c113806af25d94b7257e (diff)
downloadbcm5719-llvm-b1137c42fa9173e60c4396e1607205785c35bbe7.tar.gz
bcm5719-llvm-b1137c42fa9173e60c4396e1607205785c35bbe7.zip
[LoopSimplify] Fix incorrect SCEV invalidation
In the function `simplifyOneLoop` we optimistically assume that changes in the inner loop only affect this very loop and have no impact on its parents. In fact, after rL329047 has been merged, we can now calculate exit counts for outer loops which may depend on inner loops. Thus, we need to invalidate all parents when we do something to a loop. There is an evidence of incorrect behavior of `simplifyOneLoop`: when we insert `SE->verify()` check in the end of this funciton, it fails on a bunch of existing test, in particular: LLVM :: Transforms/LoopUnroll/peel-loop-not-forced.ll LLVM :: Transforms/LoopUnroll/peel-loop-pgo.ll LLVM :: Transforms/LoopUnroll/peel-loop.ll LLVM :: Transforms/LoopUnroll/peel-loop2.ll Note that previously we have fixed issues of this variety, see rL328483. This patch makes this function invalidate the outermost loop properly. Differential Revision: https://reviews.llvm.org/D45937 Reviewed By: chandlerc llvm-svn: 330576
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud