summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms/Utils/InlineFunction.cpp
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2010-05-01 01:15:56 +0000
committerChris Lattner <sabre@nondot.org>2010-05-01 01:15:56 +0000
commitfc8d9ee6c392a3d4badf588ee0415fac23494a4c (patch)
treebd990353ed618cdc00a3ab0768612636418257f5 /llvm/lib/Transforms/Utils/InlineFunction.cpp
parente8262675a3b71e613a0595a01bd67d9e096b2cda (diff)
downloadbcm5719-llvm-fc8d9ee6c392a3d4badf588ee0415fac23494a4c.tar.gz
bcm5719-llvm-fc8d9ee6c392a3d4badf588ee0415fac23494a4c.zip
Implement rdar://6295824 and PR6724 with two tiny changes
that can have a big effect :). The first is to enable the iterative SCC passmanager juice that kicks in when the scc passmgr detects that a function pass has devirtualized a call. In this case, it will rerun all the passes it manages on the SCC, up to the iteration count limit (4). This is useful because a function pass may devirualize a call, and we want the inliner to inline it, or pruneeh to infer stuff about it, etc. The second patch is to add *all* call sites to the DevirtualizedCalls list the inliner uses. This list is about to get renamed, but the jist of this is that the inliner now reconsiders *all* inlined call sites as candidates for further inlining. The intuition is this that in cases like this: f() { g(1); } g(int x) { h(x); } We analyze this bottom up, and may decide that it isn't profitable to inline H into G. Next step, we decide that it is profitable to inline G into F, and do so, which means that F now calls H. Even though the call from G -> H may not have been profitable to inline, the call from F -> H may be (in this case because a constant allows folding etc). In my spot checks, this doesn't have a big impact on code. For example, the LLC output for 252.eon grew from 0.02% (from 317252 to 317308) and 176.gcc actually shrunk by .3% (from 1525612 to 1520964 bytes). 252.eon never iterated in the SCC Passmgr, 176.gcc iterated at most 1 time. llvm-svn: 102823
Diffstat (limited to 'llvm/lib/Transforms/Utils/InlineFunction.cpp')
-rw-r--r--llvm/lib/Transforms/Utils/InlineFunction.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/Utils/InlineFunction.cpp b/llvm/lib/Transforms/Utils/InlineFunction.cpp
index 481cacf5a19..c30f51444b4 100644
--- a/llvm/lib/Transforms/Utils/InlineFunction.cpp
+++ b/llvm/lib/Transforms/Utils/InlineFunction.cpp
@@ -219,6 +219,7 @@ static void UpdateCallGraphAfterInlining(CallSite CS,
}
CallerNode->addCalledFunction(CallSite::get(NewCall), I->second);
+ IFI.DevirtualizedCalls.push_back(NewCall);
}
// Update the call graph by deleting the edge from Callee to Caller. We must
OpenPOWER on IntegriCloud