summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms/Utils/CodeExtractor.cpp
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2018-12-05 19:35:37 +0000
committerVedant Kumar <vsk@apple.com>2018-12-05 19:35:37 +0000
commit09415a850ec927e45a1639a621c2a3a6aba2687c (patch)
tree8be20e9864818e12ec29de0797abe8cc715b1d71 /llvm/lib/Transforms/Utils/CodeExtractor.cpp
parentc10590f6f99385aa4f0209e42d5136b11355d5a8 (diff)
downloadbcm5719-llvm-09415a850ec927e45a1639a621c2a3a6aba2687c.tar.gz
bcm5719-llvm-09415a850ec927e45a1639a621c2a3a6aba2687c.zip
[CodeExtractor] Do not marked outlined calls which may resume EH as noreturn
Treat terminators which resume exception propagation as returning instructions (at least, for the purposes of marking outlined functions `noreturn`). This is to avoid inserting traps after calls to outlined functions which unwind. rdar://46129950 llvm-svn: 348404
Diffstat (limited to 'llvm/lib/Transforms/Utils/CodeExtractor.cpp')
-rw-r--r--llvm/lib/Transforms/Utils/CodeExtractor.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Utils/CodeExtractor.cpp b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
index a22789153df..dbcee9e5755 100644
--- a/llvm/lib/Transforms/Utils/CodeExtractor.cpp
+++ b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
@@ -1369,9 +1369,12 @@ Function *CodeExtractor::extractCodeRegion() {
DVI->eraseFromParent();
}
- // Mark the new function `noreturn` if applicable.
+ // Mark the new function `noreturn` if applicable. Terminators which resume
+ // exception propagation are treated as returning instructions. This is to
+ // avoid inserting traps after calls to outlined functions which unwind.
bool doesNotReturn = none_of(*newFunction, [](const BasicBlock &BB) {
- return isa<ReturnInst>(BB.getTerminator());
+ const Instruction *Term = BB.getTerminator();
+ return isa<ReturnInst>(Term) || isa<ResumeInst>(Term);
});
if (doesNotReturn)
newFunction->setDoesNotReturn();
OpenPOWER on IntegriCloud