diff options
| author | Pete Cooper <peter_cooper@apple.com> | 2015-05-12 20:05:31 +0000 |
|---|---|---|
| committer | Pete Cooper <peter_cooper@apple.com> | 2015-05-12 20:05:31 +0000 |
| commit | 833f34d837eca1e11370fbdea0bcbae10fee70b7 (patch) | |
| tree | 715708db84c3689da9353f39f85088f86359bbe1 /llvm/lib/Transforms/Utils/BasicBlockUtils.cpp | |
| parent | 26b7aa020bdcabd10ba1c81226327007321aeb89 (diff) | |
| download | bcm5719-llvm-833f34d837eca1e11370fbdea0bcbae10fee70b7.tar.gz bcm5719-llvm-833f34d837eca1e11370fbdea0bcbae10fee70b7.zip | |
Convert PHI getIncomingValue() to foreach over incoming_values(). NFC.
We already had a method to iterate over all the incoming values of a PHI. This just changes all eligible code to use it.
Ineligible code included anything which cared about the index, or was also trying to get the i'th incoming BB.
llvm-svn: 237169
Diffstat (limited to 'llvm/lib/Transforms/Utils/BasicBlockUtils.cpp')
| -rw-r--r-- | llvm/lib/Transforms/Utils/BasicBlockUtils.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp b/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp index b4552576e46..f3c801348a6 100644 --- a/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp +++ b/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp @@ -136,8 +136,8 @@ bool llvm::MergeBlockIntoPredecessor(BasicBlock *BB, DominatorTree *DT, // Can't merge if there is PHI loop. for (BasicBlock::iterator BI = BB->begin(), BE = BB->end(); BI != BE; ++BI) { if (PHINode *PN = dyn_cast<PHINode>(BI)) { - for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) - if (PN->getIncomingValue(i) == PN) + for (Value *IncValue : PN->incoming_values()) + if (IncValue == PN) return false; } else break; |
