diff options
author | Diego Novillo <dnovillo@google.com> | 2014-04-17 22:33:50 +0000 |
---|---|---|
committer | Diego Novillo <dnovillo@google.com> | 2014-04-17 22:33:50 +0000 |
commit | 0915c047c2e8d94eb9c8e726e10e2d1ef63db29c (patch) | |
tree | 3dbea92edbbe7dccd491690c6c7cc56a0548f660 /llvm/lib/Transforms/Utils/AddDiscriminators.cpp | |
parent | 9ced19abe89a248963b629528ff3e0fee930ed98 (diff) | |
download | bcm5719-llvm-0915c047c2e8d94eb9c8e726e10e2d1ef63db29c.tar.gz bcm5719-llvm-0915c047c2e8d94eb9c8e726e10e2d1ef63db29c.zip |
Fix bug 19437 - Only add discriminators for DWARF 4 and above.
Summary:
This prevents the discriminator generation pass from triggering if
the DWARF version being used in the module is prior to 4.
Reviewers: echristo, dblaikie
CC: llvm-commits
Differential Revision: http://reviews.llvm.org/D3413
llvm-svn: 206507
Diffstat (limited to 'llvm/lib/Transforms/Utils/AddDiscriminators.cpp')
-rw-r--r-- | llvm/lib/Transforms/Utils/AddDiscriminators.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Utils/AddDiscriminators.cpp b/llvm/lib/Transforms/Utils/AddDiscriminators.cpp index f42635e335d..a4d813871e6 100644 --- a/llvm/lib/Transforms/Utils/AddDiscriminators.cpp +++ b/llvm/lib/Transforms/Utils/AddDiscriminators.cpp @@ -154,10 +154,15 @@ static bool hasDebugInfo(const Function &F) { /// file and line location as I2. This new lexical block will have a /// different discriminator number than I1. bool AddDiscriminators::runOnFunction(Function &F) { - // No need to do anything if there is no debug info for this function. // If the function has debug information, but the user has disabled // discriminators, do nothing. - if (!hasDebugInfo(F) || NoDiscriminators) return false; + // Simlarly, if the function has no debug info, do nothing. + // Finally, if this module is built with dwarf versions earlier than 4, + // do nothing (discriminator support is a DWARF 4 feature). + if (NoDiscriminators || + !hasDebugInfo(F) || + F.getParent()->getDwarfVersion() < 4) + return false; bool Changed = false; Module *M = F.getParent(); |