summaryrefslogtreecommitdiffstats
path: root/llvm/lib/Transforms/Scalar
diff options
context:
space:
mode:
authorWei Mi <wmi@google.com>2017-08-29 21:45:11 +0000
committerWei Mi <wmi@google.com>2017-08-29 21:45:11 +0000
commitebb93277590c0e8553f5278724cb96f912dc0dc0 (patch)
treec42a7013d049830cb5a4114bac2d26c661ec880a /llvm/lib/Transforms/Scalar
parent045205239567cfe3a9f4e73ccf02085763dba5e1 (diff)
downloadbcm5719-llvm-ebb93277590c0e8553f5278724cb96f912dc0dc0.tar.gz
bcm5719-llvm-ebb93277590c0e8553f5278724cb96f912dc0dc0.zip
[LoopUnswitch] Fix a simple bug which disables loop unswitch for select statement
This is to fix PR34257. rL309059 takes an early return when FindLIVLoopCondition fails to find a loop invariant condition. This is wrong and it will disable loop unswitch for select. The patch fixes the bug. Differential Revision: https://reviews.llvm.org/D36985 llvm-svn: 312045
Diffstat (limited to 'llvm/lib/Transforms/Scalar')
-rw-r--r--llvm/lib/Transforms/Scalar/LoopUnswitch.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
index 4a48d90e716..bf830dd6377 100644
--- a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
@@ -705,10 +705,8 @@ bool LoopUnswitch::processCurrentLoop() {
// unswitch on it if we desire.
Value *LoopCond = FindLIVLoopCondition(BI->getCondition(),
currentLoop, Changed).first;
- if (!LoopCond || EqualityPropUnSafe(*LoopCond))
- continue;
-
- if (UnswitchIfProfitable(LoopCond, ConstantInt::getTrue(Context), TI)) {
+ if (LoopCond && !EqualityPropUnSafe(*LoopCond) &&
+ UnswitchIfProfitable(LoopCond, ConstantInt::getTrue(Context), TI)) {
++NumBranches;
return true;
}
OpenPOWER on IntegriCloud