diff options
author | Davide Italiano <davide@freebsd.org> | 2016-12-09 03:08:42 +0000 |
---|---|---|
committer | Davide Italiano <davide@freebsd.org> | 2016-12-09 03:08:42 +0000 |
commit | 824d6952310f6fa127cd14efb52017adc8d058f3 (patch) | |
tree | aa64f665af6412576927f7ecfa0114baaa52fcc4 /llvm/lib/Transforms/Scalar | |
parent | e3a0aef2cf93c7dc144c52798aa5546dc5ec304b (diff) | |
download | bcm5719-llvm-824d6952310f6fa127cd14efb52017adc8d058f3.tar.gz bcm5719-llvm-824d6952310f6fa127cd14efb52017adc8d058f3.zip |
[SCCP] Teach the pass about `mul %x 0` even if %x is overdefined.
The motivating example is:
extern int patatino;
int goo() {
int x = 0;
for (int i = 0; i < 1000000; ++i) {
x *= patatino;
}
return x;
}
Currently SCCP will not realize that this function returns always zero,
therefore will try to unroll and vectorize the loop at -O3 producing an
awful lot of (useless) code. With this change, it will just produce:
0000000000000000 <g>:
xor %eax,%eax
retq
llvm-svn: 289175
Diffstat (limited to 'llvm/lib/Transforms/Scalar')
-rw-r--r-- | llvm/lib/Transforms/Scalar/SCCP.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Scalar/SCCP.cpp b/llvm/lib/Transforms/Scalar/SCCP.cpp index 2c1364d77cf..279c710f9e1 100644 --- a/llvm/lib/Transforms/Scalar/SCCP.cpp +++ b/llvm/lib/Transforms/Scalar/SCCP.cpp @@ -916,7 +916,8 @@ void SCCPSolver::visitBinaryOperator(Instruction &I) { // If this is an AND or OR with 0 or -1, it doesn't matter that the other // operand is overdefined. - if (I.getOpcode() == Instruction::And || I.getOpcode() == Instruction::Or) { + if (I.getOpcode() == Instruction::And || I.getOpcode() == Instruction::Mul || + I.getOpcode() == Instruction::Or) { LatticeVal *NonOverdefVal = nullptr; if (!V1State.isOverdefined()) NonOverdefVal = &V1State; @@ -927,8 +928,10 @@ void SCCPSolver::visitBinaryOperator(Instruction &I) { if (NonOverdefVal->isUnknown()) return; - if (I.getOpcode() == Instruction::And) { + if (I.getOpcode() == Instruction::And || + I.getOpcode() == Instruction::Mul) { // X and 0 = 0 + // X * 0 = 0 if (NonOverdefVal->getConstant()->isNullValue()) return markConstant(IV, &I, NonOverdefVal->getConstant()); } else { |