diff options
author | Justin Bogner <mail@justinbogner.com> | 2015-12-15 19:40:57 +0000 |
---|---|---|
committer | Justin Bogner <mail@justinbogner.com> | 2015-12-15 19:40:57 +0000 |
commit | 843fb204b7102bc1abd7fdadf39f3ac2e0acb479 (patch) | |
tree | 911cfa2d243582a779de1e1edffbc4a01045d384 /llvm/lib/Transforms/Scalar/LoopDistribute.cpp | |
parent | 33beb24318f9e5355f1aa481cddcbb50eaf2a156 (diff) | |
download | bcm5719-llvm-843fb204b7102bc1abd7fdadf39f3ac2e0acb479.tar.gz bcm5719-llvm-843fb204b7102bc1abd7fdadf39f3ac2e0acb479.zip |
LPM: Stop threading `Pass *` through all of the loop utility APIs. NFC
A large number of loop utility functions take a `Pass *` and reach
into it to find out which analyses to preserve. There are a number of
problems with this:
- The APIs have access to pretty well any Pass state they want, so
it's hard to tell what they may or may not do.
- Other APIs have copied these and pass around a `Pass *` even though
they don't even use it. Some of these just hand a nullptr to the API
since the callers don't even have a pass available.
- Passes in the new pass manager don't work like the current ones, so
the APIs can't be used as is there.
Instead, we should explicitly thread the analysis results that we
actually care about through these APIs. This is both simpler and more
reusable.
llvm-svn: 255669
Diffstat (limited to 'llvm/lib/Transforms/Scalar/LoopDistribute.cpp')
-rw-r--r-- | llvm/lib/Transforms/Scalar/LoopDistribute.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp index fce063ab40a..3d3cf3e2890 100644 --- a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp +++ b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp @@ -377,7 +377,7 @@ public: /// \brief This performs the main chunk of the work of cloning the loops for /// the partitions. - void cloneLoops(Pass *P) { + void cloneLoops() { BasicBlock *OrigPH = L->getLoopPreheader(); // At this point the predecessor of the preheader is either the memcheck // block or the top part of the original preheader. @@ -796,7 +796,7 @@ private: // Create identical copies of the original loop for each partition and hook // them up sequentially. - Partitions.cloneLoops(this); + Partitions.cloneLoops(); // Now, we remove the instruction from each loop that don't belong to that // partition. |