diff options
| author | Vedant Kumar <vsk@apple.com> | 2018-02-16 01:15:20 +0000 |
|---|---|---|
| committer | Vedant Kumar <vsk@apple.com> | 2018-02-16 01:15:20 +0000 |
| commit | 616fdb00dfe09c889980ef6d42b98ee67b2694c4 (patch) | |
| tree | b68215e5ca4062711324f77b28834eb62dda6704 /llvm/lib/Transforms/Scalar/GVN.cpp | |
| parent | 65b620be8a63c8dee5225562a43c6dfc827394a7 (diff) | |
| download | bcm5719-llvm-616fdb00dfe09c889980ef6d42b98ee67b2694c4.tar.gz bcm5719-llvm-616fdb00dfe09c889980ef6d42b98ee67b2694c4.zip | |
[GVN] Partially revert debug info salvage change (r325063)
In r325063, we salvaged debug values from dying instructions in
GVN::processBlock() and GVN::performScalarPRE().
The change in performScalarPRE(), while correct, is unhelpful. It
introduced a call to salvageDebugInfo() which was immediately followed
by a RAUW, meaning it prevented the RAUW from efficiently updating
dbg.value intrinsics. This commit reverts the mistake and tightens up
the affected test case.
llvm-svn: 325308
Diffstat (limited to 'llvm/lib/Transforms/Scalar/GVN.cpp')
| -rw-r--r-- | llvm/lib/Transforms/Scalar/GVN.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index a9104408691..9c291bde547 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -2321,7 +2321,6 @@ bool GVN::performScalarPRE(Instruction *CurInst) { VN.eraseTranslateCacheEntry(ValNo, *CurrentBlock); addToLeaderTable(ValNo, Phi, CurrentBlock); Phi->setDebugLoc(CurInst->getDebugLoc()); - salvageDebugInfo(*CurInst); CurInst->replaceAllUsesWith(Phi); if (MD && Phi->getType()->isPtrOrPtrVectorTy()) MD->invalidateCachedPointerInfo(Phi); |
