diff options
| author | Daniel Neilson <dneilson@azul.com> | 2018-02-08 21:28:26 +0000 |
|---|---|---|
| committer | Daniel Neilson <dneilson@azul.com> | 2018-02-08 21:28:26 +0000 |
| commit | 606cf6f64f775723e6865dec2f1161691e2f67e9 (patch) | |
| tree | 614a719d02bbdf8162b39613b5fb0083a3b8b9ba /llvm/lib/Transforms/Instrumentation | |
| parent | a98d9d92da4fdc36296a4d63218a38d800ec634e (diff) | |
| download | bcm5719-llvm-606cf6f64f775723e6865dec2f1161691e2f67e9.tar.gz bcm5719-llvm-606cf6f64f775723e6865dec2f1161691e2f67e9.zip | |
[DSan] Update uses of memory intrinsic get/setAlignment to new API (NFC)
Summary:
This change is part of step five in the series of changes to remove alignment argument from
memcpy/memmove/memset in favour of alignment attributes. In particular, this changes the
DataFlowSanitizer pass to cease using the old get/setAlignment() API of MemoryIntrinsic
in favour of getting source & dest specific alignments through the new API.
Steps:
Step 1) Remove alignment parameter and create alignment parameter attributes for
memcpy/memmove/memset. ( rL322965, rC322964, rL322963 )
Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing
source and dest alignments. ( rL323597 )
Step 3) Update Clang to use the new IRBuilder API. ( rC323617 )
Step 4) Update Polly to use the new IRBuilder API. ( rL323618 )
Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API,
and those that use use MemIntrinsicInst::[get|set]Alignment() to use [get|set]DestAlignment()
and [get|set]SourceAlignment() instead. ( rL323886, rL323891, rL324148, rL324273, rL324278,
rL324384, rL324395, rL324402, rL324626, rL324642, rL324653 )
Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the
MemIntrinsicInst::[get|set]Alignment() methods.
Reference
http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.html
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html
llvm-svn: 324654
Diffstat (limited to 'llvm/lib/Transforms/Instrumentation')
| -rw-r--r-- | llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp index 9c90d27d6d5..54b6f4424ea 100644 --- a/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp +++ b/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp @@ -1388,12 +1388,12 @@ void DFSanVisitor::visitMemTransferInst(MemTransferInst &I) { auto *MTI = cast<MemTransferInst>( IRB.CreateCall(I.getCalledValue(), {DestShadow, SrcShadow, LenShadow, I.getVolatileCst()})); - // FIXME: Set the source & dest alignments of MTI based on the separate - // source & dest alignments of I if (ClPreserveAlignment) { - MTI->setAlignment(I.getAlignment() * (DFSF.DFS.ShadowWidth / 8)); + MTI->setDestAlignment(I.getDestAlignment() * (DFSF.DFS.ShadowWidth / 8)); + MTI->setSourceAlignment(I.getSourceAlignment() * (DFSF.DFS.ShadowWidth / 8)); } else { - MTI->setAlignment(DFSF.DFS.ShadowWidth / 8); + MTI->setDestAlignment(DFSF.DFS.ShadowWidth / 8); + MTI->setSourceAlignment(DFSF.DFS.ShadowWidth / 8); } } |

