diff options
author | Evgeniy Stepanov <eugeni.stepanov@gmail.com> | 2014-03-18 09:47:06 +0000 |
---|---|---|
committer | Evgeniy Stepanov <eugeni.stepanov@gmail.com> | 2014-03-18 09:47:06 +0000 |
commit | 2aac07349d548ba67d9ff12f8689ee79c319e3f6 (patch) | |
tree | 05a1fd08541b8afb00d094aef378eb98047198a5 /llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp | |
parent | ad312155a6a357e3ed73232f8f945f2bd75886b4 (diff) | |
download | bcm5719-llvm-2aac07349d548ba67d9ff12f8689ee79c319e3f6.tar.gz bcm5719-llvm-2aac07349d548ba67d9ff12f8689ee79c319e3f6.zip |
[msan] Kill -msan-store-clean-origin flag.
Not only is it slower than the alternative, but also subtly broken.
This commit does not change the default behavior.
llvm-svn: 204131
Diffstat (limited to 'llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp')
-rw-r--r-- | llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp b/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp index 7b966565f05..99114d1414f 100644 --- a/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp +++ b/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp @@ -160,10 +160,6 @@ static cl::opt<bool> ClHandleICmpExact("msan-handle-icmp-exact", cl::desc("exact handling of relational integer ICmp"), cl::Hidden, cl::init(false)); -static cl::opt<bool> ClStoreCleanOrigin("msan-store-clean-origin", - cl::desc("store origin for clean (fully initialized) values"), - cl::Hidden, cl::init(false)); - // This flag controls whether we check the shadow of the address // operand of load or store. Such bugs are very rare, since load from // a garbage address typically results in SEGV, but still happen @@ -547,7 +543,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> { if (MS.TrackOrigins) { unsigned Alignment = std::max(kMinOriginAlignment, I.getAlignment()); - if (ClStoreCleanOrigin || isa<StructType>(Shadow->getType())) { + if (isa<StructType>(Shadow->getType())) { IRB.CreateAlignedStore(getOrigin(Val), getOriginPtr(Addr, IRB), Alignment); } else { |