diff options
author | Sanjay Patel <spatel@rotateright.com> | 2015-12-09 16:17:20 +0000 |
---|---|---|
committer | Sanjay Patel <spatel@rotateright.com> | 2015-12-09 16:17:20 +0000 |
commit | 07410ed234702081a1fa42f1bc950421147c2c6c (patch) | |
tree | 7e4dcec3fc4000af7680054a9dfcdc73b53140e7 /llvm/lib/Transforms/InstCombine | |
parent | b000bbdec22c555746686f7d937ce9b7c7fd77e9 (diff) | |
download | bcm5719-llvm-07410ed234702081a1fa42f1bc950421147c2c6c.tar.gz bcm5719-llvm-07410ed234702081a1fa42f1bc950421147c2c6c.zip |
[InstCombine] fold bitcasts around an extractelement
Example:
bitcast (extractelement (bitcast <2 x float> %X to <2 x i32>), 1) to float
--->
extractelement <2 x float> %X, i32 1
This is part of fixing PR25543:
https://llvm.org/bugs/show_bug.cgi?id=25543
The next step will be to generalize this fold:
trunc ( lshr ( bitcast X) ) -> extractelement (X)
Ie, I'm hoping to replace the existing transform of:
bitcast ( trunc ( lshr ( bitcast X)))
added by:
http://reviews.llvm.org/rL112232
with 2 less specific transforms to catch the case in the bug report.
Differential Revision: http://reviews.llvm.org/D14879
llvm-svn: 255124
Diffstat (limited to 'llvm/lib/Transforms/InstCombine')
-rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp index 4afe1bb243f..23bf40124b5 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp @@ -1715,6 +1715,40 @@ static Value *optimizeIntegerToVectorInsertions(BitCastInst &CI, return Result; } +/// Given a bitcasted vector fed into an extract element instruction and then +/// bitcasted again, eliminate at least one bitcast by changing the vector type +/// of the extractelement instruction. +/// Example: +/// bitcast (extractelement (bitcast <2 x float> %X to <2 x i32>), 1) to float +/// ---> +/// extractelement <2 x float> %X, i32 1 +static Instruction *foldBitCastExtElt(BitCastInst &BitCast, InstCombiner &IC, + const DataLayout &DL) { + // TODO: Create and use a pattern matcher for ExtractElementInst. + auto *ExtElt = dyn_cast<ExtractElementInst>(BitCast.getOperand(0)); + if (!ExtElt || !ExtElt->hasOneUse()) + return nullptr; + + Value *InnerBitCast = nullptr; + if (!match(ExtElt->getOperand(0), m_BitCast(m_Value(InnerBitCast)))) + return nullptr; + + VectorType *VecType = cast<VectorType>(InnerBitCast->getType()); + Type *DestType = BitCast.getType(); + + // If the element type of the vector doesn't match the result type, + // bitcast it to a vector type that we can extract from. + if (VecType->getElementType() != DestType) { + unsigned VecWidth = VecType->getPrimitiveSizeInBits(); + unsigned DestWidth = DestType->getPrimitiveSizeInBits(); + unsigned NumElts = VecWidth / DestWidth; + VecType = VectorType::get(DestType, NumElts); + InnerBitCast = IC.Builder->CreateBitCast(InnerBitCast, VecType, "bc"); + } + + return ExtractElementInst::Create(InnerBitCast, ExtElt->getOperand(1)); +} + static Instruction *foldVecTruncToExtElt(Value *VecInput, Type *DestTy, unsigned ShiftAmt, InstCombiner &IC, const DataLayout &DL) { @@ -1886,6 +1920,9 @@ Instruction *InstCombiner::visitBitCast(BitCastInst &CI) { } } + if (Instruction *I = foldBitCastExtElt(CI, *this, DL)) + return I; + if (SrcTy->isPointerTy()) return commonPointerCastTransforms(CI); return commonCastTransforms(CI); |