diff options
| author | Nick Lewycky <nicholas@mxc.ca> | 2015-04-13 19:17:37 +0000 |
|---|---|---|
| committer | Nick Lewycky <nicholas@mxc.ca> | 2015-04-13 19:17:37 +0000 |
| commit | abe2cc17dac0eacc47f2bbc4a41fa1ccc7ad8fe1 (patch) | |
| tree | fab87b3109ec0f1f662b1af604af96401e786902 /llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp | |
| parent | 2114275263405e842f34a313297889c5064535f5 (diff) | |
| download | bcm5719-llvm-abe2cc17dac0eacc47f2bbc4a41fa1ccc7ad8fe1.tar.gz bcm5719-llvm-abe2cc17dac0eacc47f2bbc4a41fa1ccc7ad8fe1.zip | |
Subtraction is not commutative. Fixes PR23212!
llvm-svn: 234780
Diffstat (limited to 'llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp')
| -rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp index e084d3d8b03..223bba03507 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp @@ -2112,7 +2112,8 @@ static Instruction *ProcessUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS, Value *RHS, Instruction &OrigI, Value *&Result, Constant *&Overflow) { - assert(!(isa<Constant>(LHS) && !isa<Constant>(RHS)) && + assert((!OrigI.isCommutative() || + !(isa<Constant>(LHS) && !isa<Constant>(RHS))) && "call with a constant RHS if possible!"); auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) { |
